Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

Issue 2339813004: Fix UMA naming. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
index 306a0dc0a6a443c47c16b94b3058d7e541fbbc3c..819d4b6d914b0a106a57f502cda242ce28791836 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
@@ -53,16 +53,16 @@ void JavaScriptDialogTabHelper::RunJavaScriptDialog(
engagement_score);
int32_t message_length = static_cast<int32_t>(message_text.length());
if (engagement_score == 0) {
- UMA_HISTOGRAM_COUNTS("JSDialogs.CountOfCharacters.EngagementNone",
+ UMA_HISTOGRAM_COUNTS("JSDialogs.CharacterCount.EngagementNone",
message_length);
} else if (engagement_score < 1) {
- UMA_HISTOGRAM_COUNTS("JSDialogs.CountOfCharacters.EngagementLessThanOne",
+ UMA_HISTOGRAM_COUNTS("JSDialogs.CharacterCount.EngagementLessThanOne",
message_length);
} else if (engagement_score < 5) {
- UMA_HISTOGRAM_COUNTS("JSDialogs.CountOfCharacters.EngagementOneToFive",
+ UMA_HISTOGRAM_COUNTS("JSDialogs.CharacterCount.EngagementOneToFive",
message_length);
} else {
- UMA_HISTOGRAM_COUNTS("JSDialogs.CountOfCharacters.EngagementHigher",
+ UMA_HISTOGRAM_COUNTS("JSDialogs.CharacterCount.EngagementHigher",
message_length);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698