Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2339813003: Improved optional command handling in SkParsePath::FromSVGString() (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Improved optional command handling in SkParsePath::FromSVGString() Repeating command letters are optional in SVG path data strings: https://www.w3.org/TR/SVG/paths.html#PathData FromSVGString() already supports this feature, but only checks for scalars prefixes == (digit | '-' | '+'). A decimal point is also a valid scalar prefix though, so it should be included in the test. R=caryclark@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339813003 Committed: https://skia.googlesource.com/skia/+/a17411f056cca6875910a4588f8596ed88e75b7c

Patch Set 1 #

Patch Set 2 : extra test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M src/utils/SkParsePath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ParsePathTest.cpp View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
f(malita)
Discovered while importing Android vector assets. This allows us to parse stuff like "H.10.20.30.40.50".
4 years, 3 months ago (2016-09-14 15:06:55 UTC) #3
caryclark
lgtm
4 years, 3 months ago (2016-09-14 17:05:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339813003/20001
4 years, 3 months ago (2016-09-14 17:12:54 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 17:14:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a17411f056cca6875910a4588f8596ed88e75b7c

Powered by Google App Engine
This is Rietveld 408576698