Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2339813002: Remove references to svn version control. (Closed)

Created:
4 years, 3 months ago by fbarchard1
Modified:
4 years, 3 months ago
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : re-add set LLVM_REPO_URL=svn://svn.chromium.org/llvm-project as a comment. #

Patch Set 3 : remove doc on llvm svn repo and update script for windows. they likely still work, but are not need… #

Patch Set 4 : remove doc on llvm svn repo and update script for windows. they likely still work, but are not need… #

Patch Set 5 : add the line: call python tools\clang\scripts\update.py to show how to update the compiler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M codereview.settings View 1 chunk +0 lines, -1 line 0 comments Download
M docs/getting_started.md View 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M setup_links.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
fbarchard1
4 years, 3 months ago (2016-09-14 00:47:54 UTC) #1
fbarchard1
try bots pass
4 years, 3 months ago (2016-09-14 01:48:51 UTC) #2
kjellander_chromium
https://codereview.chromium.org/2339813002/diff/1/docs/getting_started.md File docs/getting_started.md (left): https://codereview.chromium.org/2339813002/diff/1/docs/getting_started.md#oldcode88 docs/getting_started.md:88: set LLVM_REPO_URL=svn://svn.chromium.org/llvm-project After looking at https://cs.chromium.org/chromium/src/tools/clang/scripts/update.py I can confirm ...
4 years, 3 months ago (2016-09-14 05:08:17 UTC) #3
fbarchard1
https://codereview.chromium.org/2339813002/diff/1/docs/getting_started.md File docs/getting_started.md (left): https://codereview.chromium.org/2339813002/diff/1/docs/getting_started.md#oldcode88 docs/getting_started.md:88: set LLVM_REPO_URL=svn://svn.chromium.org/llvm-project On 2016/09/14 05:08:17, kjellander_chromium wrote: > After ...
4 years, 3 months ago (2016-09-14 17:15:10 UTC) #4
kjellander_chromium
lgtm
4 years, 3 months ago (2016-09-14 18:56:04 UTC) #5
fbarchard1
4 years, 3 months ago (2016-09-14 21:54:51 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
742be44654f5bccc9ff64a20e9afeb5b77916616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698