Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2339793002: Handle newCursorPosition correctly for Android's commitText() (Closed)
Patch Set: Fix compile error (rebased on r418371) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index df10703544a33e2ce1d019202d94a22f391e0976..95d380e5a32a995fe5f0a5efffc63adae8b2bc26 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -947,19 +947,6 @@ void WebLocalFrameImpl::replaceSelection(const WebString& text)
frame()->editor().replaceSelectionWithText(text, selectReplacement, smartReplace);
}
-void WebLocalFrameImpl::insertText(const WebString& text)
-{
- if (frame()->inputMethodController().hasComposition()) {
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
-
- frame()->inputMethodController().confirmComposition(text);
- } else {
- frame()->editor().insertText(text, 0);
- }
-}
-
void WebLocalFrameImpl::setMarkedText(const WebString& text, unsigned location, unsigned length)
{
Vector<CompositionUnderline> decorations;
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698