content/renderer/pepper/pepper_plugin_instance_impl.cc - Issue 2339793002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 2339793002: Handle newCursorPosition correctly for Android's commitText() (Closed)

Patch Set: Fix compile error (rebased on r418371) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc

index 6c56fc6a427985460a65f5b3ac57c119e241adf9..492fa3282002020a1167e5be61a4c4d51f025974 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -2241,7 +2241,7 @@ bool PepperPluginInstanceImpl::SimulateIMEEvent(

case PP_INPUTEVENT_TYPE_IME_TEXT:

if (!render_frame_)

return false;

- render_frame_->SimulateImeConfirmComposition(

+ render_frame_->SimulateImeCommitText(

base::UTF8ToUTF16(input_event.character_text), gfx::Range());

break;

default: