Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 2339793002: Handle newCursorPosition correctly for Android's commitText() (Closed)
Patch Set: Fix compile error (rebased on r418371) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index 99092e4ba99f2a870b097f51a661c7778080d6f5..6fac1db912ccf321633db160d154b472f206756d 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -118,9 +118,11 @@ class CONTENT_EXPORT BrowserPlugin :
const blink::WebVector<blink::WebCompositionUnderline>& underlines,
int selectionStart,
int selectionEnd) override;
- bool confirmComposition(
- const blink::WebString& text,
- blink::WebWidget::ConfirmCompositionBehavior selectionBehavior) override;
+ bool commitText(const blink::WebString& text,
+ int relative_cursor_pos) override;
+ bool finishComposingText(
+ blink::WebWidget::ConfirmCompositionBehavior selection_behavior) override;
+
void extendSelectionAndDelete(int before, int after) override;
// MouseLockDispatcher::LockTarget implementation.

Powered by Google App Engine
This is Rietveld 408576698