Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2339793002: Handle newCursorPosition correctly for Android's commitText() (Closed)
Patch Set: Fix compile error (rebased on r418371) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 1fd39b62337e6c881635ccc1726ee61875a02299..dcfef1ba765ada142dd4ac74fff834b1d8e07eda 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -1365,8 +1365,7 @@ void RenderWidgetHostViewAura::SetCompositionText(
void RenderWidgetHostViewAura::ConfirmCompositionText() {
if (text_input_manager_ && text_input_manager_->GetActiveWidget() &&
has_composition_text_) {
- text_input_manager_->GetActiveWidget()->ImeConfirmComposition(
- base::string16(), gfx::Range::InvalidRange(), false);
+ text_input_manager_->GetActiveWidget()->ImeFinishComposingText(false);
}
has_composition_text_ = false;
}
@@ -1382,8 +1381,11 @@ void RenderWidgetHostViewAura::InsertText(const base::string16& text) {
DCHECK_NE(GetTextInputType(), ui::TEXT_INPUT_TYPE_NONE);
if (text_input_manager_ && text_input_manager_->GetActiveWidget()) {
- text_input_manager_->GetActiveWidget()->ImeConfirmComposition(
- text, gfx::Range::InvalidRange(), false);
+ if (text.length())
+ text_input_manager_->GetActiveWidget()->ImeCommitText(
+ text, gfx::Range::InvalidRange(), 0);
+ else if (has_composition_text_)
+ text_input_manager_->GetActiveWidget()->ImeFinishComposingText(false);
}
has_composition_text_ = false;
}
@@ -2490,8 +2492,7 @@ void RenderWidgetHostViewAura::FinishImeCompositionSession() {
return;
if (!!text_input_manager_ && !!text_input_manager_->GetActiveWidget()) {
- text_input_manager_->GetActiveWidget()->ImeConfirmComposition(
- base::string16(), gfx::Range::InvalidRange(), false);
+ text_input_manager_->GetActiveWidget()->ImeFinishComposingText(false);
}
ImeCancelComposition();
}

Powered by Google App Engine
This is Rietveld 408576698