Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2339753002: MD Settings: Initialize google_brand code in ResetSettingsHandlerTest. (Closed)

Created:
4 years, 3 months ago by dpapad
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Initialize google_brand code in ResetSettingsHandlerTest. BUG=644451 Committed: https://crrev.com/340cb81a1ebbe7755ed784af71f164544dbbd2cc Cr-Commit-Position: refs/heads/master@{#418585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dpapad
4 years, 3 months ago (2016-09-14 00:19:50 UTC) #2
Dan Beam
lgtm if it fixes the issue though globals in tests = </3
4 years, 3 months ago (2016-09-14 01:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339753002/1
4 years, 3 months ago (2016-09-14 01:33:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/295872)
4 years, 3 months ago (2016-09-14 02:09:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339753002/1
4 years, 3 months ago (2016-09-14 16:23:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 16:36:07 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 16:40:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/340cb81a1ebbe7755ed784af71f164544dbbd2cc
Cr-Commit-Position: refs/heads/master@{#418585}

Powered by Google App Engine
This is Rietveld 408576698