Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2339743002: Nanobench SVG support (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : speculative gn fix #

Patch Set 3 : speculative gn fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -11 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M bench/nanobench.cpp View 1 9 chunks +55 lines, -11 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
f(malita)
4 years, 3 months ago (2016-09-13 23:14:45 UTC) #4
mtklein
lgtm
4 years, 3 months ago (2016-09-14 14:58:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339743002/40001
4 years, 3 months ago (2016-09-14 15:04:06 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 15:05:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6519c21a57946366c1141fa81fe1b283150b43fc

Powered by Google App Engine
This is Rietveld 408576698