Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7447)

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

Issue 2339733003: Transform redirect chains for the Safe Browsing subresource filter. (Closed)
Patch Set: Use std::prev(). Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/safe_browsing_resource_throttle.cc
diff --git a/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc b/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc
index a917f501a18c2fdcd31cfcfbec68f092e377a83e..d7ce65b3411c366fd94bcf0bf0b7f45f7365893f 100644
--- a/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc
+++ b/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/renderer_host/safe_browsing_resource_throttle.h"
+#include <iterator>
#include <utility>
#include "base/logging.h"
@@ -300,13 +301,28 @@ void SafeBrowsingResourceThrottle::StartDisplayingBlockingPage(
prerender::PrerenderContents* prerender_contents =
prerender::PrerenderContents::FromWebContents(web_contents);
- subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory =
- subresource_filter::ContentSubresourceFilterDriverFactory::
- FromWebContents(web_contents);
- DCHECK(driver_factory);
- driver_factory->OnMainResourceMatchedSafeBrowsingBlacklist(
- resource.url, resource.redirect_urls, resource.threat_type,
- resource.threat_metadata.threat_pattern_type);
+ // Once activated, the subresource filter will filters subresources, but is
+ // triggered when the main frame document matches Safe Browsing blacklists.
+ if (!resource.is_subresource) {
+ using subresource_filter::ContentSubresourceFilterDriverFactory;
+ ContentSubresourceFilterDriverFactory* driver_factory =
+ ContentSubresourceFilterDriverFactory::FromWebContents(web_contents);
+ DCHECK(driver_factory);
+
+ // For a redirect chain of A -> B -> C, the subresource filter expects C
+ // as the resource URL and [A, B] as redirect URLs.
+ std::vector<GURL> redirect_parent_urls;
+ if (!resource.redirect_urls.empty()) {
+ redirect_parent_urls.push_back(resource.original_url);
+ redirect_parent_urls.insert(redirect_parent_urls.end(),
+ resource.redirect_urls.begin(),
+ std::prev(resource.redirect_urls.end()));
+ }
+
+ driver_factory->OnMainResourceMatchedSafeBrowsingBlacklist(
+ resource.url, redirect_parent_urls, resource.threat_type,
+ resource.threat_metadata.threat_pattern_type);
+ }
if (prerender_contents) {
prerender_contents->Destroy(prerender::FINAL_STATUS_SAFE_BROWSING);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698