chrome/browser/resources/settings/people_page/people_page.js - Issue 2339723002: Add Signin_Impression_FromSettings user action for Desktops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2339723002: Add Signin_Impression_FromSettings user action for Desktops (Closed)

Patch Set: address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/people_page/people_page.js

diff --git a/chrome/browser/resources/settings/people_page/people_page.js b/chrome/browser/resources/settings/people_page/people_page.js

index 42622f135709d3beeff493f5414155ac4a7990df..6858d898e90a728d3df4a76b67636e70dd522b2e 100644

--- a/chrome/browser/resources/settings/people_page/people_page.js

+++ b/chrome/browser/resources/settings/people_page/people_page.js

@@ -184,6 +184,9 @@ Polymer({

* @private

handleSyncStatus_: function(syncStatus) {

+ if (!this.syncStatus && syncStatus && !syncStatus.signedIn) {

+ chrome.metricsPrivate.recordUserAction('Signin_Impression_FromSettings');

+ }

this.syncStatus = syncStatus;

« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | no next file » | no next file with comments »