Add Signin_Impression_FromSettings user action for Desktops

chrome/browser/resources/settings/people_page/people_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-people-page' is the settings page containing sign-in settings.
  */
 Polymer({
   is: 'settings-people-page',
@@ skipping 166 matching lines @@
   handleProfileManagesSupervisedUsers_: function(managesSupervisedUsers) {
     this.profileManagesSupervisedUsers_ = managesSupervisedUsers;
   },
 
   /**
    * Handler for when the sync state is pushed from the browser.
    * @param {?settings.SyncStatus} syncStatus
    * @private
    */
   handleSyncStatus_: function(syncStatus) {
+    if (this.syncStatus == null && !syncStatus.signedIn) {

[Dan Beam, 2016/09/16 18:03:03]

if (!this.syncStatus && syncStatus && !syncStatus.signedIn)
  chrome.metricsPrivate.recordUserAction('Signin_Impression_FromSettings');

[gogerald1, 2016/09/16 20:18:07]

Done.

[Dan Beam, 2016/09/16 21:46:36]

for future reference, I meant not to use curly braces (like the rest of the
code), which is why I wrote it the way I did

+      chrome.metricsPrivate.recordUserAction('Signin_Impression_FromSettings');
+    }
     this.syncStatus = syncStatus;
   },
 
 <if expr="chromeos">
   /**
    * Handler for when the Easy Unlock enabled status has changed.
    * @private
    */
   handleEasyUnlockEnabledStatusChanged_: function(easyUnlockEnabled) {
     this.easyUnlockEnabled_ = easyUnlockEnabled;
@@ skipping 152 matching lines @@
 
   /**
    * @param {string} iconUrl
    * @return {string} A CSS imageset for multiple scale factors.
    * @private
    */
   getIconImageset_: function(iconUrl) {
     return cr.icon.getImage(iconUrl);
   },
 });