Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2339703004: mark dart2js kernel tests as slow (Closed)

Created:
4 years, 3 months ago by Harry Terkelsen
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

mark dart2js kernel tests as slow since we have to build all of dart:core for every test, it can take a long time R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a175f914c2bc0daa8a3e6c77ead4997fad5f88c3

Patch Set 1 #

Patch Set 2 : mark dart2js kernel tests as slow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/compiler/dart2js/dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 3 months ago (2016-09-14 18:38:48 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 3 months ago (2016-09-14 19:21:10 UTC) #3
Harry Terkelsen
4 years, 3 months ago (2016-09-14 20:08:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a175f914c2bc0daa8a3e6c77ead4997fad5f88c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698