Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2339683006: [Blink] Modify SuspendableScriptExecutor to take a v8::Function (Closed)
Patch Set: Haraken's Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebLocalFrame.h
diff --git a/third_party/WebKit/public/web/WebLocalFrame.h b/third_party/WebKit/public/web/WebLocalFrame.h
index 505a63dd190cfeb9537b0b873353fcf45a17752b..1e1d95bcda6c5c94709d1dc95907cd82101c56e5 100644
--- a/third_party/WebKit/public/web/WebLocalFrame.h
+++ b/third_party/WebKit/public/web/WebLocalFrame.h
@@ -188,6 +188,14 @@ class WebLocalFrame : public WebFrame {
bool userGesture,
WebScriptExecutionCallback*) = 0;
+ // Requests execution of the given function, but allowing for script
+ // suspension and asynchronous execution.
+ virtual void requestExecuteV8Function(v8::Local<v8::Function>,
dcheng 2016/10/04 05:59:53 Also, I forgot to save this comment the first time
Devlin 2016/10/04 19:40:05 I'm happy to. Done.
+ v8::Local<v8::Value> receiver,
+ int argc,
+ v8::Local<v8::Value> argv[],
+ WebScriptExecutionCallback*) = 0;
+
// worldID must be > 0 (as 0 represents the main world).
// worldID must be < EmbedderWorldIdLimit, high number used internally.
virtual void requestExecuteScriptInIsolatedWorld(

Powered by Google App Engine
This is Rietveld 408576698