[Blink] Modify SuspendableScriptExecutor to take a v8::Function

extensions/renderer/script_context.h

Index: extensions/renderer/script_context.h
diff --git a/extensions/renderer/script_context.h b/extensions/renderer/script_context.h
index dd97ac90dc3871d8b7c8d095aec42e33eec09c66..ae06dfc77f0aab43640bcc5601f4c9d641396dca 100644
--- a/extensions/renderer/script_context.h
+++ b/extensions/renderer/script_context.h
@@ -118,6 +118,13 @@ class ScriptContext : public RequestSender::Source {
   v8::Local<v8::Value> CallFunction(
       const v8::Local<v8::Function>& function) const;
 
+  // Safely calls the v8::Function, respecting the page load deferrer and
+  // possibly executing asynchronously.
+  // TODO(devlin): Remove the above variants in favor of this.

[dcheng, 2016/10/04 05:58:49]

Btw, do you estimate that this will be a lot of work if we're just trying to fix
extension code?

[Devlin, 2016/10/04 19:40:05]

It's hard to say until I really start in on it.  I think I ran into at least a
few cases where we relied on the result, which would need to be restructured. 
I'm hoping there aren't any where we synchronously return a result to an
extension, because that would be very difficult indeed.

+  void SafeCallFunction(const v8::Local<v8::Function>& function,
+                        int argc,
+                        v8::Local<v8::Value> argv[]);
+
   void DispatchEvent(const char* event_name, v8::Local<v8::Array> args) const;
 
   // Returns the availability of the API |api_name|.