third_party/WebKit/Source/web/DEPS - Issue 2339683006: [Blink] Modify SuspendableScriptExecutor to take a v8::Function

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/web/DEPS

Issue 2339683006: [Blink] Modify SuspendableScriptExecutor to take a v8::Function (Closed)

Patch Set: polish Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+..",	2 "+..",

3 "+bindings",	3 "+bindings",

4 "+core",	4 "+core",

5 "+gin/public",	5 "+gin/public",

6 "+heap",	6 "+heap",

7 "+modules",	7 "+modules",

8 "+painting",	8 "+painting",

9 "+platform",	9 "+platform",

10 "+public",	10 "+public",

11 "+public/platform",	11 "+public/platform",

12 "+skia",	12 "+skia",

13 "+third_party/khronos",	13 "+third_party/khronos",

14 "+third_party/skia",	14 "+third_party/skia",

15 "+ui/gfx/geometry",	15 "+ui/gfx/geometry",

	16 "+v8",
	Devlin 2016/09/16 18:16:31 I'm guessing folks will object to this. I'm guessing folks will object to this. dcheng 2016/09/27 08:30:57 I think this is OK (I'm a little surprised this is Show quoted text On 2016/09/16 18:16:31, Devlin (catching up) wrote: > I'm guessing folks will object to this. I think this is OK (I'm a little surprised this is required, it looks like there's a bunch of references to v8 types already) Devlin 2016/09/27 22:14:20 No longer needed with #include<>. Show quoted text On 2016/09/27 08:30:57, dcheng wrote: > On 2016/09/16 18:16:31, Devlin (catching up) wrote: > > I'm guessing folks will object to this. > > I think this is OK (I'm a little surprised this is required, it looks like > there's a bunch of references to v8 types already) No longer needed with #include<>.
16 "+web",	17 "+web",

17 ]	18 ]

OLD	NEW