Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2339683005: [DevTools] Migrate FileBasedSearchResultsPane to TreeOutlineInShadow. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate FileBasedSearchResultsPane to TreeOutlineInShadow. This is a step towards turning all tree outlines into independent web components, removing global styles related to it and allowing more components to encapsulate their inner details. BUG=none Committed: https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09 Cr-Commit-Position: refs/heads/master@{#418782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -122 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js View 1 chunk +2 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/sources/fileBasedSearchResultsPane.css View 1 chunk +98 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css View 2 chunks +0 lines, -118 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-14 21:28:08 UTC) #2
lushnikov
lgtm
4 years, 3 months ago (2016-09-15 01:27:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339683005/1
4 years, 3 months ago (2016-09-15 03:11:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 04:45:04 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 04:46:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e53b1921cdcfb0397ad769205f8be28eeb39a09
Cr-Commit-Position: refs/heads/master@{#418782}

Powered by Google App Engine
This is Rietveld 408576698