Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2339683003: [Subzero][MIPS] Fix test nacl-other-intrinsics.ll (Closed)

Created:
4 years, 3 months ago by sagar.thakur
Modified:
4 years, 3 months ago
Reviewers:
srdjan.obucina, Eric Holk, Karl, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com, jaydeep.patil, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Subzero][MIPS] Fix test nacl-other-intrinsics.ll The test nacl-other-intrinsics.ll fails with an assertion failure: assert(SpillAreaAlignmentBytes <= MIPS32_STACK_ALIGNMENT_BYTES). This assertion triggers because MIPS32_STACK_ALIGNMENT_BYTES is 8 and SpillAreaAlignmentBytes is 16. The minimum required alignment of stack for MIPS32 is 8 bytes according to the ABI document. Since 16 is aligned to 8, we can safely keep the stack aligned to 16 bytes to fix the test. R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ccbb6d16d412d90532d4873b0bfe7f5ee93dbc50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M src/IceTargetLoweringMIPS32.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 9 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sagar.thakur
4 years, 3 months ago (2016-09-14 10:44:15 UTC) #2
Jim Stichnoth
lgtm
4 years, 3 months ago (2016-09-14 13:08:41 UTC) #3
Jim Stichnoth
4 years, 3 months ago (2016-09-14 13:09:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ccbb6d16d412d90532d4873b0bfe7f5ee93dbc50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698