Do not clear the favicon for an in-page navigation.

Do not clear the favicon for an in-page navigation.

BUG=642302, 28515
TEST=as in bug 642302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/cba7c6edb3c1eee02484e62e91c080b0603b41be
Cr-Commit-Position: refs/heads/master@{#418775}

[Avi (use Gerrit), 2016-09-13 20:56:38]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-09-13 20:56:39]

Description was changed from

==========
Do not clear the favicon for an in-page navigation.

BUG=642302,28515
TEST=as in bug 642302
==========

to

==========
Do not clear the favicon for an in-page navigation.

BUG=642302,28515
TEST=as in bug 642302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Avi (use Gerrit), 2016-09-13 20:57:30]

avi@chromium.org changed reviewers:
+ creis@chromium.org

[Avi (use Gerrit), 2016-09-13 20:57:31]

:)

[commit-bot: I haz the power, 2016-09-13 20:57:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 22:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 22:59:34]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-09-14 19:25:32]

Ah, interesting.  Yeah, seems fine, and I don't immediately see other things in
there needing the same check.  LGTM.

(Is it easy to add a test similar to NavigationControllerTest's
BackNavigationDoesNotClearFavicon from
https://chromiumcodereview.appspot.com/11198007/diff/22003/content/browser/we...
 If not, I'm ok landing without a test.)

[Avi (use Gerrit), 2016-09-14 20:14:04]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-09-14 20:14:43]

I thought that a test would be hard, but no, it's not. So here you go. (Yes,
verified that it fails without the fix.)

[commit-bot: I haz the power, 2016-09-14 20:15:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 21:06:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 21:06:12]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-09-14 22:07:19]

Hooray!  LGTM.

[Avi (use Gerrit), 2016-09-15 04:11:11]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-09-15 04:11:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 04:15:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 04:19:07]

Description was changed from

==========
Do not clear the favicon for an in-page navigation.

BUG=642302,28515
TEST=as in bug 642302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Do not clear the favicon for an in-page navigation.

BUG=642302,28515
TEST=as in bug 642302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/cba7c6edb3c1eee02484e62e91c080b0603b41be
Cr-Commit-Position: refs/heads/master@{#418775}
==========

[commit-bot: I haz the power, 2016-09-15 04:19:09]

Patchset 2 (id:??) landed as
https://crrev.com/cba7c6edb3c1eee02484e62e91c080b0603b41be
Cr-Commit-Position: refs/heads/master@{#418775}