mash: Port KeyboardUIMus to mojo:ash; remove sysui.

mash: Port KeyboardUIMus to mojo:ash; remove sysui.

Move ash/sysui/keyboard_ui_mus.* to ash/mus.
Instantiate KeyboardUIMus from WmShellMus.
Avoid null pointer access in mash_unittests.

Cleanup [AshWindowTreeHost|Shell]InitParams.
Remove Shell::in_mus_ and accessor.
Remove ash/sysui directory and contents.

BUG=616857
TEST=No ChromeOS keyboard changes.
R=sky@chromium.org
TBR=dpranke@chromium.org

Committed: https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43
Cr-Commit-Position: refs/heads/master@{#418381}

[msw, 2016-09-13 19:46:49]

Hey Scott, please take a look; thanks!

[msw, 2016-09-13 19:46:58]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 19:47:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-13 20:09:47]

Nice! LGTM

https://codereview.chromium.org/2339633002/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right):

https://codereview.chromium.org/2339633002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:959: }
File a but for the else case and a NOTIMPLEMENTED?

[msw, 2016-09-13 20:36:56]

https://codereview.chromium.org/2339633002/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right):

https://codereview.chromium.org/2339633002/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:959: }
On 2016/09/13 20:09:47, sky wrote:
> File a but for the else case and a NOTIMPLEMENTED?

Done.

[msw, 2016-09-13 20:36:59]

The CQ bit was checked by msw@chromium.org

[msw, 2016-09-13 20:37:00]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2339633002/#ps20001
(title: "Add mash NOTIMPLEMENTED() in
AccessibilityManager::UpdateVirtualKeyboardFromPref()")

[commit-bot: I haz the power, 2016-09-13 20:37:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:45:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 20:45:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2016-09-13 20:59:16]

Description was changed from

==========
mash: Port KeyboardUIMus to mojo:ash; remove sysui.

Move ash/sysui/keyboard_ui_mus.* to ash/mus.
Instantiate KeyboardUIMus from WmShellMus.
Avoid null pointer access in mash_unittests.

Cleanup [AshWindowTreeHost|Shell]InitParams.
Remove Shell::in_mus_ and accessor.
Remove ash/sysui directory and contents.

BUG=616857
TEST=No ChromeOS keyboard changes.
R=sky@chromium.org
==========

to

==========
mash: Port KeyboardUIMus to mojo:ash; remove sysui.

Move ash/sysui/keyboard_ui_mus.* to ash/mus.
Instantiate KeyboardUIMus from WmShellMus.
Avoid null pointer access in mash_unittests.

Cleanup [AshWindowTreeHost|Shell]InitParams.
Remove Shell::in_mus_ and accessor.
Remove ash/sysui directory and contents.

BUG=616857
TEST=No ChromeOS keyboard changes.
R=sky@chromium.org
TBR=dpranke@chromium.org
==========

[msw, 2016-09-13 20:59:16]

msw@chromium.org changed reviewers:
+ dpranke@chromium.org

[msw, 2016-09-13 20:59:46]

+TBR Dirk for compare_build_artifacts.py

[msw, 2016-09-13 20:59:56]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-09-13 21:00:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-09-13 21:36:17]

lgtm

[commit-bot: I haz the power, 2016-09-13 21:49:36]

Description was changed from

==========
mash: Port KeyboardUIMus to mojo:ash; remove sysui.

Move ash/sysui/keyboard_ui_mus.* to ash/mus.
Instantiate KeyboardUIMus from WmShellMus.
Avoid null pointer access in mash_unittests.

Cleanup [AshWindowTreeHost|Shell]InitParams.
Remove Shell::in_mus_ and accessor.
Remove ash/sysui directory and contents.

BUG=616857
TEST=No ChromeOS keyboard changes.
R=sky@chromium.org
TBR=dpranke@chromium.org
==========

to

==========
mash: Port KeyboardUIMus to mojo:ash; remove sysui.

Move ash/sysui/keyboard_ui_mus.* to ash/mus.
Instantiate KeyboardUIMus from WmShellMus.
Avoid null pointer access in mash_unittests.

Cleanup [AshWindowTreeHost|Shell]InitParams.
Remove Shell::in_mus_ and accessor.
Remove ash/sysui directory and contents.

BUG=616857
TEST=No ChromeOS keyboard changes.
R=sky@chromium.org
TBR=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2016-09-13 21:49:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 21:53:16]

Description was changed from

==========
mash: Port KeyboardUIMus to mojo:ash; remove sysui.

Move ash/sysui/keyboard_ui_mus.* to ash/mus.
Instantiate KeyboardUIMus from WmShellMus.
Avoid null pointer access in mash_unittests.

Cleanup [AshWindowTreeHost|Shell]InitParams.
Remove Shell::in_mus_ and accessor.
Remove ash/sysui directory and contents.

BUG=616857
TEST=No ChromeOS keyboard changes.
R=sky@chromium.org
TBR=dpranke@chromium.org
==========

to

==========
mash: Port KeyboardUIMus to mojo:ash; remove sysui.

Move ash/sysui/keyboard_ui_mus.* to ash/mus.
Instantiate KeyboardUIMus from WmShellMus.
Avoid null pointer access in mash_unittests.

Cleanup [AshWindowTreeHost|Shell]InitParams.
Remove Shell::in_mus_ and accessor.
Remove ash/sysui directory and contents.

BUG=616857
TEST=No ChromeOS keyboard changes.
R=sky@chromium.org
TBR=dpranke@chromium.org

Committed: https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43
Cr-Commit-Position: refs/heads/master@{#418381}
==========

[commit-bot: I haz the power, 2016-09-13 21:53:17]

Patchset 2 (id:??) landed as
https://crrev.com/15156bf5e576f3894a1eac72f2802f88ca59dd43
Cr-Commit-Position: refs/heads/master@{#418381}