Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 233963002: Remove null-check for page. (Closed)

Created:
6 years, 8 months ago by ojan
Modified:
6 years, 8 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Remove null-check for page. I don't see how we could have a null page here. I put an assert(page) in CompositingReasonFinder::updateTriggers to verify that no tests hit this. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ojan
6 years, 8 months ago (2014-04-10 21:24:58 UTC) #1
eseidel
lgtm We shouldn't ever be compositing w/o a page.
6 years, 8 months ago (2014-04-10 21:48:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/233963002/1
6 years, 8 months ago (2014-04-10 21:48:42 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 23:01:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-10 23:01:47 UTC) #5
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 8 months ago (2014-04-10 23:03:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/233963002/1
6 years, 8 months ago (2014-04-10 23:03:36 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 23:05:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-10 23:05:31 UTC) #9
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 8 months ago (2014-04-11 16:58:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/233963002/1
6 years, 8 months ago (2014-04-11 16:58:19 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 18:08:54 UTC) #12
Message was sent while issue was closed.
Change committed as 171361

Powered by Google App Engine
This is Rietveld 408576698