|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Jamie Madill Modified:
4 years, 2 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd angle_unittests to Linux ASAN bot.
BUG=644846
Committed: https://crrev.com/ed2f409a8253512a291d883230241b6ff75b985f
Cr-Commit-Position: refs/heads/master@{#418371}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by jmadill@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add angle_unittests to Linux ASAN bot. BUG=644846 ========== to ========== Add angle_unittests to Linux ASAN bot. BUG=644846 ==========
jmadill@chromium.org changed reviewers: + dpranke@chromium.org
PTAL
thakis@chromium.org changed reviewers: + thakis@chromium.org
lgtm, thanks (it already ran on https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... :-) )
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add angle_unittests to Linux ASAN bot. BUG=644846 ========== to ========== Add angle_unittests to Linux ASAN bot. BUG=644846 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add angle_unittests to Linux ASAN bot. BUG=644846 ========== to ========== Add angle_unittests to Linux ASAN bot. BUG=644846 Committed: https://crrev.com/ed2f409a8253512a291d883230241b6ff75b985f Cr-Commit-Position: refs/heads/master@{#418371} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ed2f409a8253512a291d883230241b6ff75b985f Cr-Commit-Position: refs/heads/master@{#418371}
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
On 2016/09/13 21:40:14, Dirk Pranke wrote: > lgtm I noticed today that these tests are really slow: https://build.chromium.org/p/tryserver.chromium.linux/stats/linux_chromium_as... 10% of the bot's time is spent on them. Can we shard then 10-ways to make the bot faster? (Should be a 3 line change, with one line containing just a brace)
Message was sent while issue was closed.
On 2016/09/22 03:22:57, Nico wrote: > On 2016/09/13 21:40:14, Dirk Pranke wrote: > > lgtm > > I noticed today that these tests are really slow: > https://build.chromium.org/p/tryserver.chromium.linux/stats/linux_chromium_as... > 10% of the bot's time is spent on them. Can we shard then 10-ways to make the > bot faster? (Should be a 3 line change, with one line containing just a brace) Attempted this in https://codereview.chromium.org/2365353003 . Not sure if I got the syntax correct. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
