Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2339613002: Add angle_unittests to Linux ASAN bot. (Closed)

Created:
4 years, 3 months ago by Jamie Madill
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add angle_unittests to Linux ASAN bot. BUG=644846 Committed: https://crrev.com/ed2f409a8253512a291d883230241b6ff75b985f Cr-Commit-Position: refs/heads/master@{#418371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M testing/buildbot/chromium.memory.json View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Jamie Madill
PTAL
4 years, 3 months ago (2016-09-13 21:05:43 UTC) #7
Nico
lgtm, thanks (it already ran on https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/225714 :-) )
4 years, 3 months ago (2016-09-13 21:07:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339613002/1
4 years, 3 months ago (2016-09-13 21:09:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 21:15:09 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed2f409a8253512a291d883230241b6ff75b985f Cr-Commit-Position: refs/heads/master@{#418371}
4 years, 3 months ago (2016-09-13 21:16:56 UTC) #15
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-13 21:40:14 UTC) #16
Nico
On 2016/09/13 21:40:14, Dirk Pranke wrote: > lgtm I noticed today that these tests are ...
4 years, 3 months ago (2016-09-22 03:22:57 UTC) #17
Jamie Madill
4 years, 2 months ago (2016-09-26 14:45:21 UTC) #18
Message was sent while issue was closed.
On 2016/09/22 03:22:57, Nico wrote:
> On 2016/09/13 21:40:14, Dirk Pranke wrote:
> > lgtm
> 
> I noticed today that these tests are really slow:
>
https://build.chromium.org/p/tryserver.chromium.linux/stats/linux_chromium_as...
> 10% of the bot's time is spent on them. Can we shard then 10-ways to make the
> bot faster? (Should be a 3 line change, with one line containing just a brace)

Attempted this in https://codereview.chromium.org/2365353003 . Not sure if I got
the syntax correct.

Powered by Google App Engine
This is Rietveld 408576698