Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: blimp/client/core/contents/android/ime_helper_dialog.cc

Issue 2339603002: Remove using base::android statements from blimp (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/contents/android/ime_helper_dialog.cc
diff --git a/blimp/client/core/contents/android/ime_helper_dialog.cc b/blimp/client/core/contents/android/ime_helper_dialog.cc
index 9bfcff18d2da1fc03478cc8d3f60175e62a3a567..b8e0fa5e54a0c06f04add0639add3d2431c92605 100644
--- a/blimp/client/core/contents/android/ime_helper_dialog.cc
+++ b/blimp/client/core/contents/android/ime_helper_dialog.cc
@@ -9,8 +9,6 @@
#include "jni/ImeHelperDialog_jni.h"
#include "ui/android/window_android.h"
-using base::android::JavaParamRef;
-
namespace blimp {
namespace client {
@@ -48,9 +46,10 @@ void ImeHelperDialog::OnHideImeRequested() {
Java_ImeHelperDialog_onHideImeRequested(env, java_obj_);
}
-void ImeHelperDialog::OnImeTextEntered(JNIEnv* env,
- const JavaParamRef<jobject>& jobj,
- const JavaParamRef<jstring>& text) {
+void ImeHelperDialog::OnImeTextEntered(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& jobj,
+ const base::android::JavaParamRef<jstring>& text) {
std::string text_input = base::android::ConvertJavaStringToUTF8(env, text);
base::ResetAndReturn(&text_submit_callback_).Run(text_input);
}
« no previous file with comments | « blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698