Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: blimp/client/app/android/toolbar.cc

Issue 2339603002: Remove using base::android statements from blimp (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/app/android/toolbar.h" 5 #include "blimp/client/app/android/toolbar.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "blimp/client/app/android/blimp_client_session_android.h" 8 #include "blimp/client/app/android/blimp_client_session_android.h"
9 #include "components/url_formatter/url_fixer.h" 9 #include "components/url_formatter/url_fixer.h"
10 #include "jni/Toolbar_jni.h" 10 #include "jni/Toolbar_jni.h"
11 #include "third_party/skia/include/core/SkBitmap.h" 11 #include "third_party/skia/include/core/SkBitmap.h"
12 #include "ui/gfx/android/java_bitmap.h" 12 #include "ui/gfx/android/java_bitmap.h"
13 #include "url/gurl.h" 13 #include "url/gurl.h"
14 14
15 using base::android::JavaParamRef;
16 using base::android::ScopedJavaLocalRef;
17
18 namespace blimp { 15 namespace blimp {
19 namespace client { 16 namespace client {
20 17
21 namespace { 18 namespace {
22 19
23 const int kDummyTabId = 0; 20 const int kDummyTabId = 0;
24 21
25 } // namespace 22 } // namespace
26 23
27 static jlong Init(JNIEnv* env, 24 static jlong Init(
28 const JavaParamRef<jobject>& jobj, 25 JNIEnv* env,
29 const JavaParamRef<jobject>& blimp_client_session) { 26 const base::android::JavaParamRef<jobject>& jobj,
27 const base::android::JavaParamRef<jobject>& blimp_client_session) {
30 BlimpClientSession* client_session = 28 BlimpClientSession* client_session =
31 BlimpClientSessionAndroid::FromJavaObject(env, blimp_client_session); 29 BlimpClientSessionAndroid::FromJavaObject(env, blimp_client_session);
32 30
33 return reinterpret_cast<intptr_t>( 31 return reinterpret_cast<intptr_t>(
34 new Toolbar(env, jobj, client_session->GetNavigationFeature())); 32 new Toolbar(env, jobj, client_session->GetNavigationFeature()));
35 } 33 }
36 34
37 // static 35 // static
38 bool Toolbar::RegisterJni(JNIEnv* env) { 36 bool Toolbar::RegisterJni(JNIEnv* env) {
39 return RegisterNativesImpl(env); 37 return RegisterNativesImpl(env);
40 } 38 }
41 39
42 Toolbar::Toolbar(JNIEnv* env, 40 Toolbar::Toolbar(JNIEnv* env,
43 const base::android::JavaParamRef<jobject>& jobj, 41 const base::android::JavaParamRef<jobject>& jobj,
44 NavigationFeature* navigation_feature) 42 NavigationFeature* navigation_feature)
45 : navigation_feature_(navigation_feature) { 43 : navigation_feature_(navigation_feature) {
46 java_obj_.Reset(env, jobj); 44 java_obj_.Reset(env, jobj);
47 45
48 navigation_feature_->SetDelegate(kDummyTabId, this); 46 navigation_feature_->SetDelegate(kDummyTabId, this);
49 } 47 }
50 48
51 Toolbar::~Toolbar() { 49 Toolbar::~Toolbar() {
52 navigation_feature_->RemoveDelegate(kDummyTabId); 50 navigation_feature_->RemoveDelegate(kDummyTabId);
53 } 51 }
54 52
55 void Toolbar::Destroy(JNIEnv* env, const JavaParamRef<jobject>& jobj) { 53 void Toolbar::Destroy(JNIEnv* env,
54 const base::android::JavaParamRef<jobject>& jobj) {
56 delete this; 55 delete this;
57 } 56 }
58 57
59 void Toolbar::OnUrlTextEntered(JNIEnv* env, 58 void Toolbar::OnUrlTextEntered(
60 const JavaParamRef<jobject>& jobj, 59 JNIEnv* env,
61 const JavaParamRef<jstring>& text) { 60 const base::android::JavaParamRef<jobject>& jobj,
61 const base::android::JavaParamRef<jstring>& text) {
62 std::string url = base::android::ConvertJavaStringToUTF8(env, text); 62 std::string url = base::android::ConvertJavaStringToUTF8(env, text);
63 63
64 // Build a search query, if |url| doesn't have a '.' anywhere. 64 // Build a search query, if |url| doesn't have a '.' anywhere.
65 if (url.find(".") == std::string::npos) 65 if (url.find(".") == std::string::npos)
66 url = "http://www.google.com/search?q=" + url; 66 url = "http://www.google.com/search?q=" + url;
67 67
68 GURL fixed_url = url_formatter::FixupURL(url, std::string()); 68 GURL fixed_url = url_formatter::FixupURL(url, std::string());
69 navigation_feature_->NavigateToUrlText(kDummyTabId, fixed_url.spec()); 69 navigation_feature_->NavigateToUrlText(kDummyTabId, fixed_url.spec());
70 } 70 }
71 71
72 void Toolbar::OnReloadPressed(JNIEnv* env, const JavaParamRef<jobject>& jobj) { 72 void Toolbar::OnReloadPressed(
73 JNIEnv* env,
74 const base::android::JavaParamRef<jobject>& jobj) {
73 navigation_feature_->Reload(kDummyTabId); 75 navigation_feature_->Reload(kDummyTabId);
74 } 76 }
75 77
76 void Toolbar::OnForwardPressed(JNIEnv* env, const JavaParamRef<jobject>& jobj) { 78 void Toolbar::OnForwardPressed(
79 JNIEnv* env,
80 const base::android::JavaParamRef<jobject>& jobj) {
77 navigation_feature_->GoForward(kDummyTabId); 81 navigation_feature_->GoForward(kDummyTabId);
78 } 82 }
79 83
80 jboolean Toolbar::OnBackPressed(JNIEnv* env, 84 jboolean Toolbar::OnBackPressed(
81 const JavaParamRef<jobject>& jobj) { 85 JNIEnv* env,
86 const base::android::JavaParamRef<jobject>& jobj) {
82 navigation_feature_->GoBack(kDummyTabId); 87 navigation_feature_->GoBack(kDummyTabId);
83 88
84 // TODO(dtrainor): Find a way to determine whether or not we're at the end of 89 // TODO(dtrainor): Find a way to determine whether or not we're at the end of
85 // our history stack. 90 // our history stack.
86 return true; 91 return true;
87 } 92 }
88 93
89 void Toolbar::OnUrlChanged(int tab_id, const GURL& url) { 94 void Toolbar::OnUrlChanged(int tab_id, const GURL& url) {
90 JNIEnv* env = base::android::AttachCurrentThread(); 95 JNIEnv* env = base::android::AttachCurrentThread();
91 ScopedJavaLocalRef<jstring> jurl( 96 base::android::ScopedJavaLocalRef<jstring> jurl(
92 base::android::ConvertUTF8ToJavaString(env, url.spec())); 97 base::android::ConvertUTF8ToJavaString(env, url.spec()));
93 98
94 Java_Toolbar_onEngineSentUrl(env, java_obj_, jurl); 99 Java_Toolbar_onEngineSentUrl(env, java_obj_, jurl);
95 } 100 }
96 101
97 void Toolbar::OnFaviconChanged(int tab_id, const SkBitmap& favicon) { 102 void Toolbar::OnFaviconChanged(int tab_id, const SkBitmap& favicon) {
98 JNIEnv* env = base::android::AttachCurrentThread(); 103 JNIEnv* env = base::android::AttachCurrentThread();
99 ScopedJavaLocalRef<jobject> jfavicon(gfx::ConvertToJavaBitmap(&favicon)); 104 base::android::ScopedJavaLocalRef<jobject> jfavicon(
105 gfx::ConvertToJavaBitmap(&favicon));
100 106
101 Java_Toolbar_onEngineSentFavicon(env, java_obj_, jfavicon); 107 Java_Toolbar_onEngineSentFavicon(env, java_obj_, jfavicon);
102 } 108 }
103 109
104 void Toolbar::OnTitleChanged(int tab_id, const std::string& title) { 110 void Toolbar::OnTitleChanged(int tab_id, const std::string& title) {
105 JNIEnv* env = base::android::AttachCurrentThread(); 111 JNIEnv* env = base::android::AttachCurrentThread();
106 ScopedJavaLocalRef<jstring> jtitle( 112 base::android::ScopedJavaLocalRef<jstring> jtitle(
107 base::android::ConvertUTF8ToJavaString(env, title)); 113 base::android::ConvertUTF8ToJavaString(env, title));
108 114
109 Java_Toolbar_onEngineSentTitle(env, java_obj_, jtitle); 115 Java_Toolbar_onEngineSentTitle(env, java_obj_, jtitle);
110 } 116 }
111 117
112 void Toolbar::OnLoadingChanged(int tab_id, bool loading) { 118 void Toolbar::OnLoadingChanged(int tab_id, bool loading) {
113 JNIEnv* env = base::android::AttachCurrentThread(); 119 JNIEnv* env = base::android::AttachCurrentThread();
114 120
115 Java_Toolbar_onEngineSentLoading(env, java_obj_, 121 Java_Toolbar_onEngineSentLoading(env, java_obj_,
116 static_cast<jboolean>(loading)); 122 static_cast<jboolean>(loading));
117 } 123 }
118 124
119 void Toolbar::OnPageLoadStatusUpdate(int tab_id, bool completed) { 125 void Toolbar::OnPageLoadStatusUpdate(int tab_id, bool completed) {
120 JNIEnv* env = base::android::AttachCurrentThread(); 126 JNIEnv* env = base::android::AttachCurrentThread();
121 127
122 Java_Toolbar_onEngineSentPageLoadStatusUpdate( 128 Java_Toolbar_onEngineSentPageLoadStatusUpdate(
123 env, java_obj_, static_cast<jboolean>(completed)); 129 env, java_obj_, static_cast<jboolean>(completed));
124 } 130 }
125 131
126 } // namespace client 132 } // namespace client
127 } // namespace blimp 133 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698