Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2339603002: Remove using base::android statements from blimp (Closed)

Created:
4 years, 3 months ago by nyquist
Modified:
4 years, 3 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, Torne
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove using base::android statements from blimp The blimp code contains cross platform code, linux code and Android code. To avoid confusion about where code originates from, this CL removes all 'using base::android::Foo' statements, and instead fully writes them out whenever they are used. BUG=None Committed: https://crrev.com/5d590aa99ed9fda287d27767943869fe0b03ebb4 Cr-Commit-Position: refs/heads/master@{#418598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -95 lines) Patch
M blimp/client/app/android/blimp_client_session_android.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M blimp/client/app/android/blimp_library_loader.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M blimp/client/app/android/blimp_view.cc View 7 chunks +54 lines, -50 lines 0 comments Download
M blimp/client/app/android/tab_control_feature_android.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M blimp/client/app/android/toolbar.cc View 6 chunks +23 lines, -17 lines 0 comments Download
M blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M blimp/client/core/contents/android/ime_helper_dialog.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
nyquist
dtrainor: PTAL torne: FYI
4 years, 3 months ago (2016-09-13 18:59:21 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years, 3 months ago (2016-09-14 15:44:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339603002/1
4 years, 3 months ago (2016-09-14 17:05:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 17:09:50 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 17:12:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d590aa99ed9fda287d27767943869fe0b03ebb4
Cr-Commit-Position: refs/heads/master@{#418598}

Powered by Google App Engine
This is Rietveld 408576698