Chromium Code Reviews
DescriptionRevert of Enforce capability spec renderer <--> browser (patchset #11 id:200001 of https://codereview.chromium.org/2259903002/ )
Reason for revert:
This breaks cast linux bot:
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux
content_unittests/MergeDictionaryTest.Merge crashing:
e.g. https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/31440/steps/content_unittests/logs/stdio
Received signal 11 SEGV_MAPERR 000000000018
#0 0x000002aa5b67 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7fd343c82340 <unknown>
#2 0x000002b03806 base::ListValue::AppendString()
#3 0x0000022f9abf content::MergeDictionary()
#4 0x000000c912da content::MergeDictionaryTest_Merge_Test::TestBody()
#5 0x00000291c547 testing::Test::Run()
#6 0x00000291d203 testing::TestInfo::Run()
#7 0x00000291d697 testing::TestCase::Run()
#8 0x0000029246d7 testing::internal::UnitTestImpl::RunAllTests()
#9 0x00000292432a testing::UnitTest::Run()
#10 0x0000024e4ec3 base::TestSuite::Run()
#11 0x0000024f4809 base::(anonymous namespace)::LaunchUnitTestsInternal()
#12 0x0000024f46cb base::LaunchUnitTests()
#13 0x00000137df7f main
#14 0x7fd341479ec5 __libc_start_main
#15 0x00000053229d <unknown>
r8: 0000000000000003 r9: 0000000000000001 r10: 0000000057d83dcb r11: 00007fd3415de870
r12: 00007fd341d363f8 r13: 00003fed7ca22840 r14: 0000000000000000 r15: 0000000000000000
di: 0000000000000018 si: 00007fd341d363f8 bp: 00007fd341d363e0 bx: 00003fed7ca22850
dx: 0000000000000000 ax: 00007fd341d363f8 cx: 00000000000006e8 sp: 00007fffcb1ae2b0
ip: 0000000002b03806 efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004
trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000018
[end of stack trace]
[1609/4198] MergeDictionaryTest.Merge (CRASHED)
Original issue's description:
> Enforce capability spec renderer <--> browser.
>
> This implements:
>
> - allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer.
> - adds such an overlay to chrome/browser
>
> So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review.
>
> R=rockot@chromium.org,tsepez@chromium.org
>
> Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
> Cr-Commit-Position: refs/heads/master@{#418282}
TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/b5eb9f6dc315666d09dd36b3e6ae718cd8b5f162
Cr-Commit-Position: refs/heads/master@{#418307}
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|