Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2339593002: Revert of Enforce capability spec renderer <--> browser (Closed)

Created:
4 years, 3 months ago by lazyboy
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enforce capability spec renderer <--> browser (patchset #11 id:200001 of https://codereview.chromium.org/2259903002/ ) Reason for revert: This breaks cast linux bot: https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux content_unittests/MergeDictionaryTest.Merge crashing: e.g. https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/31440/steps/content_unittests/logs/stdio Received signal 11 SEGV_MAPERR 000000000018 #0 0x000002aa5b67 base::debug::(anonymous namespace)::StackDumpSignalHandler() #1 0x7fd343c82340 <unknown> #2 0x000002b03806 base::ListValue::AppendString() #3 0x0000022f9abf content::MergeDictionary() #4 0x000000c912da content::MergeDictionaryTest_Merge_Test::TestBody() #5 0x00000291c547 testing::Test::Run() #6 0x00000291d203 testing::TestInfo::Run() #7 0x00000291d697 testing::TestCase::Run() #8 0x0000029246d7 testing::internal::UnitTestImpl::RunAllTests() #9 0x00000292432a testing::UnitTest::Run() #10 0x0000024e4ec3 base::TestSuite::Run() #11 0x0000024f4809 base::(anonymous namespace)::LaunchUnitTestsInternal() #12 0x0000024f46cb base::LaunchUnitTests() #13 0x00000137df7f main #14 0x7fd341479ec5 __libc_start_main #15 0x00000053229d <unknown> r8: 0000000000000003 r9: 0000000000000001 r10: 0000000057d83dcb r11: 00007fd3415de870 r12: 00007fd341d363f8 r13: 00003fed7ca22840 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000000018 si: 00007fd341d363f8 bp: 00007fd341d363e0 bx: 00003fed7ca22850 dx: 0000000000000000 ax: 00007fd341d363f8 cx: 00000000000006e8 sp: 00007fffcb1ae2b0 ip: 0000000002b03806 efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000018 [end of stack trace] [1609/4198] MergeDictionaryTest.Merge (CRASHED) Original issue's description: > Enforce capability spec renderer <--> browser. > > This implements: > > - allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer. > - adds such an overlay to chrome/browser > > So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review. > > R=rockot@chromium.org,tsepez@chromium.org > > Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3 > Cr-Commit-Position: refs/heads/master@{#418282} TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b5eb9f6dc315666d09dd36b3e6ae718cd8b5f162 Cr-Commit-Position: refs/heads/master@{#418307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -358 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 4 chunks +0 lines, -18 lines 0 comments Download
D chrome/browser/content_browser_manifest_overlay.json View 1 chunk +0 lines, -15 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/browser_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +1 line, -1 line 0 comments Download
D content/browser/mojo/merge_dictionary.h View 1 chunk +0 lines, -21 lines 0 comments Download
D content/browser/mojo/merge_dictionary.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/mojo/merge_dictionary_unittest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 4 chunks +9 lines, -57 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/utility_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A content/common/mojo/constants.h View 1 chunk +20 lines, -0 lines 0 comments Download
A content/common/mojo/constants.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/public/app/mojo/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 2 chunks +2 lines, -16 lines 0 comments Download
M content/public/app/mojo/content_renderer_manifest.json View 1 chunk +2 lines, -10 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/common/service_names.h View 1 chunk +0 lines, -20 lines 0 comments Download
D content/public/common/service_names.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/catalog/manifest_provider.h View 2 chunks +3 lines, -4 lines 0 comments Download
M services/catalog/reader.cc View 1 chunk +18 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
lazyboy
Created Revert of Enforce capability spec renderer <--> browser
4 years, 3 months ago (2016-09-13 18:29:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339593002/1
4 years, 3 months ago (2016-09-13 18:30:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 18:33:50 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 18:36:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5eb9f6dc315666d09dd36b3e6ae718cd8b5f162
Cr-Commit-Position: refs/heads/master@{#418307}

Powered by Google App Engine
This is Rietveld 408576698