Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2339583002: cc: Move OnScrollOffsetAnimated to scroll tree (Closed)

Created:
4 years, 3 months ago by jaydasika
Modified:
4 years, 3 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, sunxd
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move OnScrollOffsetAnimated to scroll tree BUG=638297 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/0604b910a5bb2297cd6a4fc9c2557b1a0be48a4d Cr-Commit-Position: refs/heads/master@{#418688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -21 lines) Patch
M cc/layers/layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +19 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 7 chunks +4 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/property_tree.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
jaydasika
PTAL
4 years, 3 months ago (2016-09-13 18:22:52 UTC) #2
weiliangc
LGTM. Probably need someone else for the blink part?
4 years, 3 months ago (2016-09-13 23:21:44 UTC) #7
jaydasika
vollick : Can you review changes to platform/graphics ?
4 years, 3 months ago (2016-09-13 23:23:00 UTC) #9
Ian Vollick
On 2016/09/13 23:23:00, jaydasika wrote: > vollick : Can you review changes to platform/graphics ? ...
4 years, 3 months ago (2016-09-14 17:10:57 UTC) #10
jaydasika
On 2016/09/14 17:10:57, Ian Vollick wrote: > On 2016/09/13 23:23:00, jaydasika wrote: > > vollick ...
4 years, 3 months ago (2016-09-14 17:12:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339583002/1
4 years, 3 months ago (2016-09-14 17:13:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 21:51:43 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 21:53:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0604b910a5bb2297cd6a4fc9c2557b1a0be48a4d
Cr-Commit-Position: refs/heads/master@{#418688}

Powered by Google App Engine
This is Rietveld 408576698