Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2339563003: Fix copy-paste issue in BytesConsumerTestUtil::TwoPhaseReader. (Closed)

Created:
4 years, 3 months ago by krasin1
Modified:
4 years, 3 months ago
Reviewers:
hiroshige, yhirano
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix copy-paste issue in BytesConsumerTestUtil::TwoPhaseReader. It was causing an invalid cast and was the reason for 'CFI Linux Full' bot being red. BUG=646615 Committed: https://crrev.com/92e83e4271b8e16920342834bb6948e9d2604eab Cr-Commit-Position: refs/heads/master@{#418473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
krasin1
4 years, 3 months ago (2016-09-13 21:57:18 UTC) #2
krasin1
I have now verified that the fix indeed fixes the CFI alert. Please, approve.
4 years, 3 months ago (2016-09-13 22:31:44 UTC) #3
krasin1
On 2016/09/13 22:31:44, krasin1 wrote: > I have now verified that the fix indeed fixes ...
4 years, 3 months ago (2016-09-13 22:34:38 UTC) #4
yhirano
On 2016/09/13 22:34:38, krasin1 wrote: > On 2016/09/13 22:31:44, krasin1 wrote: > > I have ...
4 years, 3 months ago (2016-09-14 00:45:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339563003/1
4 years, 3 months ago (2016-09-14 00:59:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 03:11:55 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 03:17:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92e83e4271b8e16920342834bb6948e9d2604eab
Cr-Commit-Position: refs/heads/master@{#418473}

Powered by Google App Engine
This is Rietveld 408576698