Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 233953002: Fix DEPS and project dependencies (Closed)

Created:
6 years, 8 months ago by sdefresne
Modified:
6 years, 8 months ago
Reviewers:
Lei Zhang, tfarina, blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix DEPS and project dependencies Nothing above chrome/common/ depends yet on components/bookmarks/ so remove the inclusion of components/bookmarks from chrome/browser/. No project above chrome/common_constants.gyp directly depends on components.gyp:bookmarks_core_common, so fix the dependencies. BUG=360613 R=thestig@chromium.org,tfarina@chromium.org,blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263323

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common_constants.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
sdefresne
Please have a look
6 years, 8 months ago (2014-04-10 21:23:03 UTC) #1
tfarina
Thank you for addressing my comments! +Lei for chrome/ stamp! lgtm
6 years, 8 months ago (2014-04-10 23:46:29 UTC) #2
Lei Zhang
lgtm s/aboce/above/ in the commit msg.
6 years, 8 months ago (2014-04-10 23:50:24 UTC) #3
tfarina
On 2014/04/10 23:50:24, Lei Zhang wrote: > lgtm > > s/aboce/above/ in the commit msg. ...
6 years, 8 months ago (2014-04-10 23:52:32 UTC) #4
blundell
lgtm
6 years, 8 months ago (2014-04-11 08:32:02 UTC) #5
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 8 months ago (2014-04-11 08:36:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/233953002/40001
6 years, 8 months ago (2014-04-11 08:36:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 09:40:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-11 09:40:37 UTC) #9
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 8 months ago (2014-04-11 12:06:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/233953002/40001
6 years, 8 months ago (2014-04-11 12:07:08 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 13:36:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-11 13:36:29 UTC) #13
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 8 months ago (2014-04-11 14:08:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/233953002/40001
6 years, 8 months ago (2014-04-11 14:08:41 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 15:29:31 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-11 15:29:31 UTC) #17
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 8 months ago (2014-04-11 15:54:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/233953002/60001
6 years, 8 months ago (2014-04-11 15:54:43 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 17:13:41 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-11 17:13:41 UTC) #21
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-11 17:26:36 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/233953002/60001
6 years, 8 months ago (2014-04-11 17:26:47 UTC) #23
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 20:10:32 UTC) #24
Message was sent while issue was closed.
Change committed as 263323

Powered by Google App Engine
This is Rietveld 408576698