Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2339513002: 🎀 Move repack_pseudo_locales //chrome -> //chrome/test (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move repack_pseudo_locales //chrome -> //chrome/test According to https://www.chromium.org/developers/testing/fake-bidi, it is no longer usable via --locale_pak, and so is used only by the (disabled) test bidi_checker_web_ui_test.cc. BUG=645716 Committed: https://crrev.com/cddda4b3eebaacab696a28aa18f89f92aceda3a9 Cr-Commit-Position: refs/heads/master@{#418889}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M chrome/BUILD.gn View 1 2 chunks +0 lines, -20 lines 0 comments Download
M chrome/test/BUILD.gn View 1 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
agrieve
Depends on: https://codereview.chromium.org/2320883006/
4 years, 3 months ago (2016-09-13 15:22:08 UTC) #2
brettw
lgtm
4 years, 3 months ago (2016-09-13 17:52:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339513002/1
4 years, 3 months ago (2016-09-13 19:50:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/68375) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-13 19:53:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339513002/20001
4 years, 3 months ago (2016-09-15 14:51:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339513002/20001
4 years, 3 months ago (2016-09-15 16:55:01 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 17:00:23 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:10:30 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cddda4b3eebaacab696a28aa18f89f92aceda3a9
Cr-Commit-Position: refs/heads/master@{#418889}

Powered by Google App Engine
This is Rietveld 408576698