Remove useless validation check for email type.

Remove noisy value validation warnings for email input type.

We cannot distinguish invalid email addresses
which web developers mistakenly specified.

BUG=638455
Committed: https://crrev.com/1676e3b6c99cde2e3581315e50b37e29876900d0
Cr-Commit-Position: refs/heads/master@{#419934}

[sujae33.jo, 2016-09-13 14:27:20]

The CQ bit was checked by sujae33.jo@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 14:27:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 14:27:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 14:27:49]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[sujae33.jo, 2016-09-13 14:29:02]

sujae33.jo@gmail.com changed reviewers:
+ tkent@chromium.org

[sujae33.jo, 2016-09-13 14:29:02]

hi. This is my first patch!

[tkent, 2016-09-13 16:26:09]

https://codereview.chromium.org/2339493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/forms/EmailInputType.cpp (right):

https://codereview.chromium.org/2339493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/EmailInputType.cpp:253:
NOTIMPLEMENTED();
Please remove the entire function, not remove the content of the function.
Also, this change needs to update layout tests.

[tkent, 2016-09-13 16:26:59]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 16:27:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sujae33.jo, 2016-09-13 17:13:23]

On 2016/09/13 16:26:09, tkent wrote:
>
https://codereview.chromium.org/2339493002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/forms/EmailInputType.cpp (right):
> 
>
https://codereview.chromium.org/2339493002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/forms/EmailInputType.cpp:253:
> NOTIMPLEMENTED();
> Please remove the entire function, not remove the content of the function.
> Also, this change needs to update layout tests.

thanks your comments.
I will do some more work related with layout tests.

[tkent, 2016-09-13 17:24:06]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 17:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:03:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:03:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sujae33.jo, 2016-09-17 03:48:25]

The CQ bit was checked by sujae33.jo@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 03:48:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 03:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 03:48:35]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[sujae33.jo, 2016-09-20 02:17:21]

On 2016/09/13 17:13:23, sujae33.jo wrote:
> On 2016/09/13 16:26:09, tkent wrote:
> >
>
https://codereview.chromium.org/2339493002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/html/forms/EmailInputType.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2339493002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/html/forms/EmailInputType.cpp:253:
> > NOTIMPLEMENTED();
> > Please remove the entire function, not remove the content of the function.
> > Also, this change needs to update layout tests.
> 
> thanks your comments.
> I will do some more work related with layout tests.

I have submitted new patchset.
Please Take a look, Tamura

[tkent, 2016-09-20 02:38:02]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 02:38:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 02:46:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 02:46:20]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tkent, 2016-09-20 03:01:32]

Please remove the file
third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-validity-tooShort-expected.txt
.  We don't need PASS-only *-expected.txt.

[sujae33.jo, 2016-09-20 03:21:08]

ok, thanks!

2016. 9. 20. 오후 12:01에 <tkent@chromium.org>님이 작성:

> Please remove the file
> third_party/WebKit/LayoutTests/imported/wpt/html/
> semantics/forms/constraints/form-validation-validity-tooShort-expected.txt
> . We don't need PASS-only *-expected.txt.
>
> https://codereview.chromium.org/2339493002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[sujae33.jo, 2016-09-20 03:21:08]

ok, thanks!

2016. 9. 20. 오후 12:01에 <tkent@chromium.org>님이 작성:

> Please remove the file
> third_party/WebKit/LayoutTests/imported/wpt/html/
> semantics/forms/constraints/form-validation-validity-tooShort-expected.txt
> . We don't need PASS-only *-expected.txt.
>
> https://codereview.chromium.org/2339493002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tkent, 2016-09-20 11:41:58]

Description was changed from

==========
Remove useless validation check for email type.

We cannot distinguish invalid email addresses
which web developers mistakenly specified.

BUG=638455
==========

to

==========
Remove noisy value validation warnings for email input type.

We cannot distinguish invalid email addresses
which web developers mistakenly specified.

BUG=638455
==========

[tkent, 2016-09-20 11:42:07]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-09-20 11:42:08]

lgtm

[commit-bot: I haz the power, 2016-09-20 11:42:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-09-20 13:32:54]

Oh, win_chromium_rel_ng bot failed.
Please remove CONSOLE WARNING lines from
third_party/WebKit/LayoutTests/platform/win7/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt
too.

[sujae33.jo, 2016-09-20 13:59:35]

On 2016/09/20 13:32:54, tkent wrote:
> Oh, win_chromium_rel_ng bot failed.
> Please remove CONSOLE WARNING lines from
>
third_party/WebKit/LayoutTests/platform/win7/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt
> too.

I have submitted a new patchset. please take a look.

[tkent, 2016-09-20 23:24:28]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-09-20 23:24:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2339493002/#ps120001
(title: "Remove noisy value validation warnings for email input type.")

[commit-bot: I haz the power, 2016-09-20 23:25:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 01:43:56]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-21 01:46:22]

Description was changed from

==========
Remove noisy value validation warnings for email input type.

We cannot distinguish invalid email addresses
which web developers mistakenly specified.

BUG=638455
==========

to

==========
Remove noisy value validation warnings for email input type.

We cannot distinguish invalid email addresses
which web developers mistakenly specified.

BUG=638455

Committed: https://crrev.com/1676e3b6c99cde2e3581315e50b37e29876900d0
Cr-Commit-Position: refs/heads/master@{#419934}
==========

[commit-bot: I haz the power, 2016-09-21 01:46:23]

Patchset 7 (id:??) landed as
https://crrev.com/1676e3b6c99cde2e3581315e50b37e29876900d0
Cr-Commit-Position: refs/heads/master@{#419934}