Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: net/tools/quic/stateless_rejector.cc

Issue 2339433004: Use unique_ptrs to manage callback lifetimes in some QUIC code (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/quic/stateless_rejector.cc
diff --git a/net/tools/quic/stateless_rejector.cc b/net/tools/quic/stateless_rejector.cc
index 005c335aa2a9059c664d2e330bb56ff706153481..42bab60131db58d176659a6a338c6eb12f8cd8ab 100644
--- a/net/tools/quic/stateless_rejector.cc
+++ b/net/tools/quic/stateless_rejector.cc
@@ -19,8 +19,8 @@ class StatelessRejector::ValidateCallback
~ValidateCallback() override {}
- void RunImpl(std::unique_ptr<Result> result,
- std::unique_ptr<ProofSource::Details> /* proof_source_details */)
+ void Run(std::unique_ptr<Result> result,
+ std::unique_ptr<ProofSource::Details> /* proof_source_details */)
override {
StatelessRejector* rejector_ptr = rejector_.get();
rejector_ptr->ProcessClientHello(*result, std::move(rejector_),
@@ -92,7 +92,8 @@ void StatelessRejector::Process(std::unique_ptr<StatelessRejector> rejector,
rejector_ptr->chlo_, rejector_ptr->client_address_.address(),
rejector_ptr->server_address_.address(), rejector_ptr->version_,
rejector_ptr->clock_, &rejector_ptr->proof_,
- new ValidateCallback(std::move(rejector), std::move(cb)));
+ std::unique_ptr<ValidateCallback>(
+ new ValidateCallback(std::move(rejector), std::move(cb))));
}
void StatelessRejector::ProcessClientHello(
« net/quic/core/crypto/crypto_server_test.cc ('K') | « net/quic/test_tools/crypto_test_utils_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698