Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2339433003: LibYUV: Add cleanup steps. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_chromium
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add expectations #

Patch Set 3 : Added expectations. Skipped android. #

Total comments: 1

Patch Set 4 : Included android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+980 lines, -0 lines) Patch
M scripts/slave/recipes/libyuv/libyuv.py View 1 3 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android32_mips_debug.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android32_x86_debug.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android64_x64_debug.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_arm64_debug.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_clang_debug.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug__gn_.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug_forced.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_release.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_release__gn_.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_arm64_debug.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_arm64_release.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_debug.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_release.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux32_debug.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux32_release.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug__gn_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug_forced.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_release.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_release__gn_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_asan.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_gcc.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_memcheck.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_msan.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_tsan_v2.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_ubsan.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_ubsan_vptr.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac64_debug.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac64_debug__gn_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac64_release.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac64_release__gn_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac_asan.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_debug__clang_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_debug__vs2010_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_debug__vs2012_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_debug__vs2013_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_release__clang_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_release__vs2010_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_release__vs2012_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_release__vs2013_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__clang_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__gn_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__vs2010_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__vs2012_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__vs2013_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__clang_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__gn_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__vs2010_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__vs2012_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__vs2013_.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_arm64.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_clang.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_gn.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_gn_rel.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_mips.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_rel.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x86.json View 1 3 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_arm64_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_ios_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_asan.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_forced.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_gcc.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_gn.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_gn_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_memcheck.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_msan.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_ubsan_vptr.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_asan.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_gn.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_gn_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_clang_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_gn.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_gn_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_rel.json View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ehmaldonado_chromium
I don't know if something like this would also be needed. https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/webrtc/api.py?l=306
4 years, 3 months ago (2016-09-13 11:54:26 UTC) #2
kjellander_chromium
https://codereview.chromium.org/2339433003/diff/1/scripts/slave/recipes/libyuv/libyuv.py File scripts/slave/recipes/libyuv/libyuv.py (right): https://codereview.chromium.org/2339433003/diff/1/scripts/slave/recipes/libyuv/libyuv.py#newcode12 scripts/slave/recipes/libyuv/libyuv.py:12: 'chromium', you need the 'chromium_android' recipe module in DEPS ...
4 years, 3 months ago (2016-09-13 11:59:18 UTC) #3
ehmaldonado_chromium
On 2016/09/13 11:59:18, kjellander_chromium wrote: > https://codereview.chromium.org/2339433003/diff/1/scripts/slave/recipes/libyuv/libyuv.py > File scripts/slave/recipes/libyuv/libyuv.py (right): > > https://codereview.chromium.org/2339433003/diff/1/scripts/slave/recipes/libyuv/libyuv.py#newcode12 > ...
4 years, 3 months ago (2016-09-13 13:20:10 UTC) #4
kjellander_chromium
lgtm (optional simplification in comment) https://codereview.chromium.org/2339433003/diff/40001/scripts/slave/recipes/libyuv/libyuv.py File scripts/slave/recipes/libyuv/libyuv.py (right): https://codereview.chromium.org/2339433003/diff/40001/scripts/slave/recipes/libyuv/libyuv.py#newcode29 scripts/slave/recipes/libyuv/libyuv.py:29: if api.chromium.c.TARGET_PLATFORM != 'android': ...
4 years, 3 months ago (2016-09-13 13:39:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339433003/60001
4 years, 3 months ago (2016-09-13 13:48:23 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 13:53:34 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/ec08ab2f605ed944d5a0...

Powered by Google App Engine
This is Rietveld 408576698