mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl - Issue 2339413004: Allow Mojo structs as map keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

Issue 2339413004: Allow Mojo structs as map keys (Closed)

Patch Set: Address sammc's comments and improve Blink tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/tools/bindings/generators/cpp_templates/union_traits_declaration.tmpl ('K') | « mojo/public/tools/bindings/generators/cpp_templates/union_traits_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl » ('j') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

index bfd68023090764f3e3fd72fa6f884301c4143e76..4c5ed38c998076b0d6aed51c9624c9ed16defa57 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

@@ -46,6 +46,10 @@ class {{export_attribute}} {{struct.name}} {

T, {{struct.name}}>::value>::type* = nullptr>

bool Equals(const T& other) const;

+{%- if struct|is_hashable %}

+ size_t Hash(size_t seed) const;

+{%- endif %}

{%- set serialization_result_type = "mojo::WTFArray<uint8_t>"

if for_blink else "mojo::Array<uint8_t>" %}