Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/public/js/validation_unittests.js

Issue 2339413004: Allow Mojo structs as map keys (Closed)
Patch Set: Address sammc's comments and improve Blink tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/public/cpp/bindings/lib/wtf_hash_util.h ('K') | « mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom ('k') | mojo/public/tools/bindings/generate_type_mappings.py » ('j') | mojo/public/tools/bindings/generators/cpp_templates/struct_traits_declaration.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/js/validation_unittests.js
diff --git a/mojo/public/js/validation_unittests.js b/mojo/public/js/validation_unittests.js
index f2e3dadaf7bc2ad41ffcc2ec2c16970ea37b7f3c..9f7c2f4f0576063bb8f59a1ba8f2bdb7e72107e5 100644
--- a/mojo/public/js/validation_unittests.js
+++ b/mojo/public/js/validation_unittests.js
@@ -234,9 +234,11 @@ define([
// logic in *RequestValidator and *ResponseValidator is ported from
// cpp to js.
// TODO(crbug/640298): Implement max recursion depth for JS.
+ // TODO(crbug/628104): Support struct map keys for JS.
if (testFiles[i].indexOf("overflow") != -1 ||
testFiles[i].indexOf("mthd11") != -1 ||
testFiles[i].indexOf("conformance_mthd19") != -1 ||
+ testFiles[i].indexOf("conformance_mthd20") != -1 ||
testFiles[i].indexOf("enum") != -1 ||
testFiles[i].indexOf("no_such_method") != -1 ||
testFiles[i].indexOf("invalid_request_flags") != -1 ||
« mojo/public/cpp/bindings/lib/wtf_hash_util.h ('K') | « mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom ('k') | mojo/public/tools/bindings/generate_type_mappings.py » ('j') | mojo/public/tools/bindings/generators/cpp_templates/struct_traits_declaration.tmpl » ('J')

Powered by Google App Engine
This is Rietveld 408576698