Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: mojo/public/cpp/bindings/map_traits.h

Issue 2339413004: Allow Mojo structs as map keys (Closed)
Patch Set: Revert no-longer-needed changes to clone_equals_util.h Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/map_traits.h
diff --git a/mojo/public/cpp/bindings/map_traits.h b/mojo/public/cpp/bindings/map_traits.h
index 01dd66d6a69a20fbcaaaf1c748e81eb4f579dd50..1c18b00bff4a7195c8e9d91148630882fcb86a7c 100644
--- a/mojo/public/cpp/bindings/map_traits.h
+++ b/mojo/public/cpp/bindings/map_traits.h
@@ -37,13 +37,13 @@ namespace mojo {
// static const V& GetValue(CustomConstIterator& iterator);
//
// // Returning false results in deserialization failure and causes the
-// // message pipe receiving it to be disconnected.
+// // message pipe receiving it to be disconnected. |IK| and |IK| are
yzshen1 2016/09/21 23:17:52 IK and *IV*
tibell 2016/09/22 05:17:23 Done.
+// // separate input key/value template parameters that allows for the
+// // the key/value types to be forwarded.
+// template <typename IK, typename IV>
// static bool Insert(CustomMap<K, V>& input,
-// const K& key,
-// V&& value);
-// static bool Insert(CustomMap<K, V>& input,
-// const K& key,
-// const V& value);
+// IK&& key,
+// IV&& value);
//
// static void SetToEmpty(CustomMap<K, V>* output);
// };

Powered by Google App Engine
This is Rietveld 408576698