Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: components/font_service/public/cpp/font_service_thread.cc

Issue 2339413004: Allow Mojo structs as map keys (Closed)
Patch Set: Revert no-longer-needed changes to clone_equals_util.h Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/font_service/public/cpp/font_service_thread.cc
diff --git a/components/font_service/public/cpp/font_service_thread.cc b/components/font_service/public/cpp/font_service_thread.cc
index 5d9645acea19f90b3da3103fc319a5e6323a2384..282c08c5a981a4891d7df40574cfcc7798539ac8 100644
--- a/components/font_service/public/cpp/font_service_thread.cc
+++ b/components/font_service/public/cpp/font_service_thread.cc
@@ -124,7 +124,7 @@ void FontServiceThread::OnMatchFamilyNameComplete(
DCHECK_EQ(GetThreadId(), base::PlatformThread::CurrentId());
pending_waitable_events_.erase(done_event);
- *out_valid = font_identity;
+ *out_valid = bool(font_identity);
Elliot Glaysher 2016/09/21 17:27:30 nit: font_identity.is_bound() This is what the In
tibell 2016/09/22 05:17:23 Done (using is_null).
if (font_identity) {
out_font_identity->fID = font_identity->id;
out_font_identity->fTTCIndex = font_identity->ttc_index;

Powered by Google App Engine
This is Rietveld 408576698