mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom - Issue 2339413004: Allow Mojo structs as map keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom

Issue 2339413004: Allow Mojo structs as map keys (Closed)

Patch Set: Remove left-over import Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd20_good.data ('K') | « mojo/public/interfaces/bindings/tests/test_structs.mojom ('k') | mojo/public/tools/bindings/generate_type_mappings.py » ('j') | mojo/public/tools/bindings/generators/cpp_templates/struct_traits_declaration.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom

diff --git a/mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom b/mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom

index 6a6b6e25c076b329d025f3225749e34cfd3aee0d..607319eed3630ab32b0711325fab7dadb1e2ed8d 100644

--- a/mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom

+++ b/mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom

@@ -91,6 +91,7 @@ interface ConformanceTestInterface {

Method17(array<InterfaceA> param0);

Method18(UnionA? param0);

Method19(Recursive recursive);

+ Method20(map<StructB, StructB> param0);

yzshen1 2016/09/20 23:44:40 Will this break the current Java/JS bindings? You

tibell 2016/09/21 07:10:53 Done.

};

struct BasicStruct {