Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: mojo/public/tools/bindings/generators/cpp_templates/union_traits_declaration.tmpl

Issue 2339413004: Allow Mojo structs as map keys (Closed)
Patch Set: Fix hash unit test on Windows Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {%- set mojom_type = union|get_qualified_name_for_kind %} 1 {%- set mojom_type = union|get_qualified_name_for_kind %}
2 2
3 template <> 3 template <>
4 struct {{export_attribute}} UnionTraits<{{mojom_type}}::DataView, 4 struct {{export_attribute}} UnionTraits<{{mojom_type}}::DataView,
5 {{mojom_type}}Ptr> { 5 {{mojom_type}}Ptr> {
6 static bool IsNull(const {{mojom_type}}Ptr& input) { return !input; } 6 static bool IsNull(const {{mojom_type}}Ptr& input) { return !input; }
7 static void SetToNull({{mojom_type}}Ptr* output) { output->reset(); } 7 static void SetToNull({{mojom_type}}Ptr* output) { output->reset(); }
8 8
9 static {{mojom_type}}::Tag GetTag(const {{mojom_type}}Ptr& input) { 9 static {{mojom_type}}::Tag GetTag(const {{mojom_type}}Ptr& input) {
10 return input->which(); 10 return input->which();
11 } 11 }
12 12
13 {%- for field in union.fields %} 13 {%- for field in union.fields %}
14 {%- set return_ref = field.kind|is_object_kind or 14 {%- set maybe_const_in = "" if field.kind|contains_handles_or_interfaces else "const" %}
15 field.kind|is_any_handle_or_interface_kind %} 15 {%- set maybe_const_out = "" if field.kind|contains_handles_or_interfaces or n ot field.kind|is_reference_kind else "const" %}
16 {%- if return_ref %} 16 {# We want the field accessor to be const whenever possible to allow
17 static decltype(std::declval<{{mojom_type}}>().get_{{field.name}}()) 17 structs to be used as map keys. #}
18 {{field.name}}({{mojom_type}}Ptr& input) { 18 static {{maybe_const_out}} {{field.kind|cpp_union_trait_getter_return_type}} { {field.name}}({{maybe_const_in}} {{mojom_type}}Ptr& input) {
19 return input->get_{{field.name}}(); 19 return input->get_{{field.name}}();
20 } 20 }
21 {%- else %}
22 static decltype(std::declval<{{mojom_type}}>().get_{{field.name}}())
23 {{field.name}}(const {{mojom_type}}Ptr& input) {
24 return input->get_{{field.name}}();
25 }
26 {%- endif %}
27 {%- endfor %} 21 {%- endfor %}
28 22
29 static bool Read({{mojom_type}}::DataView input, {{mojom_type}}Ptr* output); 23 static bool Read({{mojom_type}}::DataView input, {{mojom_type}}Ptr* output);
30 }; 24 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698