Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: mojo/public/js/validation_unittests.js

Issue 2339413004: Allow Mojo structs as map keys (Closed)
Patch Set: Revert no-longer-needed changes to clone_equals_util.h Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 define([ 5 define([
6 "console", 6 "console",
7 "file", 7 "file",
8 "gin/test/expect", 8 "gin/test/expect",
9 "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom", 9 "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom",
10 "mojo/public/js/buffer", 10 "mojo/public/js/buffer",
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 // TODO(yzshen) Skipping enum validation tests (tests with "enum" in the 230 // TODO(yzshen) Skipping enum validation tests (tests with "enum" in the
231 // name) because the feature is not supported in JS yet. crbug.com/581390 231 // name) because the feature is not supported in JS yet. crbug.com/581390
232 // TODO(rudominer): Temporarily skipping 'no-such-method', 232 // TODO(rudominer): Temporarily skipping 'no-such-method',
233 // 'invalid_request_flags', and 'invalid_response_flags' until additional 233 // 'invalid_request_flags', and 'invalid_response_flags' until additional
234 // logic in *RequestValidator and *ResponseValidator is ported from 234 // logic in *RequestValidator and *ResponseValidator is ported from
235 // cpp to js. 235 // cpp to js.
236 // TODO(crbug/640298): Implement max recursion depth for JS. 236 // TODO(crbug/640298): Implement max recursion depth for JS.
237 if (testFiles[i].indexOf("overflow") != -1 || 237 if (testFiles[i].indexOf("overflow") != -1 ||
238 testFiles[i].indexOf("mthd11") != -1 || 238 testFiles[i].indexOf("mthd11") != -1 ||
239 testFiles[i].indexOf("conformance_mthd19") != -1 || 239 testFiles[i].indexOf("conformance_mthd19") != -1 ||
240 testFiles[i].indexOf("conformance_mthd20") != -1 ||
yzshen1 2016/09/21 23:17:53 please also add a TODO for this.
tibell 2016/09/22 05:17:23 Done.
240 testFiles[i].indexOf("enum") != -1 || 241 testFiles[i].indexOf("enum") != -1 ||
241 testFiles[i].indexOf("no_such_method") != -1 || 242 testFiles[i].indexOf("no_such_method") != -1 ||
242 testFiles[i].indexOf("invalid_request_flags") != -1 || 243 testFiles[i].indexOf("invalid_request_flags") != -1 ||
243 testFiles[i].indexOf("invalid_response_flags") != -1) { 244 testFiles[i].indexOf("invalid_response_flags") != -1) {
244 console.log("[Skipping " + testFiles[i] + "]"); 245 console.log("[Skipping " + testFiles[i] + "]");
245 continue; 246 continue;
246 } 247 }
247 248
248 var testMessage = readTestMessage(testFiles[i]); 249 var testMessage = readTestMessage(testFiles[i]);
249 var handles = new Array(testMessage.handleCount); 250 var handles = new Array(testMessage.handleCount);
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 testConformanceMessageValidation(); 343 testConformanceMessageValidation();
343 testBoundsCheckMessageValidation(); 344 testBoundsCheckMessageValidation();
344 testResponseConformanceMessageValidation(); 345 testResponseConformanceMessageValidation();
345 testResponseBoundsCheckMessageValidation(); 346 testResponseBoundsCheckMessageValidation();
346 testIntegratedMessageHeaderValidation(); 347 testIntegratedMessageHeaderValidation();
347 testIntegratedResponseMessageValidation(); 348 testIntegratedResponseMessageValidation();
348 testIntegratedRequestMessageValidation(); 349 testIntegratedRequestMessageValidation();
349 350
350 this.result = "PASS"; 351 this.result = "PASS";
351 }); 352 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698