mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd20_good.data - Issue 2339413004: Allow Mojo structs as map keys

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd20_good.data

Issue 2339413004: Allow Mojo structs as map keys (Closed)

Patch Set: Remove left-over import Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« mojo/public/cpp/bindings/struct_ptr.h ('K') | « mojo/public/cpp/bindings/tests/wtf_map_unittest.cc ('k') | mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd20_good.expected » ('j') | mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 [dist4]message_header // num_bytes

	2 [u4]0 // version

	3 [u4]0 // interface ID

	4 [u4]10 // name
	yzshen1 2016/09/20 23:44:40 This should be 20. Otherwise we are not testing th This should be 20. Otherwise we are not testing the right method. tibell 2016/09/21 07:10:53 Done. Show quoted text On 2016/09/20 23:44:40, yzshen1 wrote: > This should be 20. Otherwise we are not testing the right method. Done.
	5 [u4]0 // flags

	6 [u4]0 // padding

	7 [anchr]message_header

	8

	9 [dist4]method10_params // num_bytes
	yzshen1 2016/09/20 23:44:40 please update the name accordingly. This is method please update the name accordingly. This is method 20. tibell 2016/09/21 07:10:53 Done. Show quoted text On 2016/09/20 23:44:40, yzshen1 wrote: > please update the name accordingly. This is method 20. Done.
	10 [u4]0 // version

	11 [dist8]map_data_ptr // param0

	12 [anchr]method10_params

	13

	14 [anchr]map_data_ptr

	15 [dist4]map_data_struct_header // num_bytes

	16 [u4]0 // version

	17 [dist8]key_array_ptr

	18 [dist8]value_array_ptr

	19 [anchr]map_data_struct_header

	20

	21 [anchr]key_array_ptr

	22 [dist4]key_array_member // num_bytes

	23 [u4]2 // num_elements

	24 [dist8]key_struct_a_1
	yzshen1 2016/09/20 23:44:40 I don't think this test case matches the parameter I don't think this test case matches the parameter definition of Method20. tibell 2016/09/21 07:10:53 Done. I changed my mind for the map value type ha Show quoted text On 2016/09/20 23:44:40, yzshen1 wrote: > I don't think this test case matches the parameter definition of Method20. Done. I changed my mind for the map value type half way through the CL and forgot to update the mojom.
	25 [dist8]key_struct_a_2

	26 [anchr]key_array_member

	27

	28 [anchr]key_struct_a_1

	29 [dist4]key_struct_a_1_member // num_bytes

	30 [u4]0 // version

	31 [u8]1234 // i

	32 [anchr]key_struct_a_1_member

	33

	34 [u4]0 [u1]0 [u1]0 [u1]0 [u1]0 // manual padding for array alignment
	tibell 2016/09/21 07:10:53 Something is wrong with the alignment (in the upda Something is wrong with the alignment (in the updated version I'm about to post). I can't figure it out. Each struct/array starts at a 8 byte alignment. Can you see the error?
	35

	36 [anchr]key_struct_a_2

	37 [dist4]key_struct_a_2_member // num_bytes

	38 [u4]0 // version

	39 [u8]1234 // i

	40 [anchr]key_struct_a_2_member

	41

	42 [u4]0 [u1]0 [u1]0 [u1]0 [u1]0 // manual padding for array alignment

	43

	44 [anchr]value_array_ptr

	45 [dist4]value_array_member // num_bytes

	46 [u4]2 // num_elements

	47 1 2

	48 [anchr]value_array_member

OLD	NEW