Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2339413003: Refactor and test jobsim_client. (Closed)

Created:
4 years, 3 months ago by iannucci
Modified:
4 years, 3 months ago
Reviewers:
dnj, Vadim Sh., estaab
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Refactor and test jobsim_client. Prereq for snapshotting (cipd/dimensions) CL R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org BUG=639975 Committed: https://github.com/luci/luci-go/commit/3e4c54f5b3a1c3304b2cf9cc66705ee4579880e1

Patch Set 1 #

Patch Set 2 : Remove old script #

Total comments: 2

Patch Set 3 : Use pool from options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -85 lines) Patch
A dm/tools/jobsim_client/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M dm/tools/jobsim_client/edit_distance.go View 6 chunks +32 lines, -22 lines 0 comments Download
A dm/tools/jobsim_client/edit_distance_test.go View 1 chunk +150 lines, -0 lines 0 comments Download
D dm/tools/jobsim_client/fire_missiles.py View 1 1 chunk +0 lines, -57 lines 0 comments Download
A dm/tools/jobsim_client/generate_ensure_graph_data_req.py View 1 2 1 chunk +177 lines, -0 lines 0 comments Download
M dm/tools/jobsim_client/main.go View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
4 years, 3 months ago (2016-09-16 01:27:05 UTC) #1
Vadim Sh.
lgtm https://codereview.chromium.org/2339413003/diff/20001/dm/tools/jobsim_client/generate_ensure_graph_data_req.py File dm/tools/jobsim_client/generate_ensure_graph_data_req.py (right): https://codereview.chromium.org/2339413003/diff/20001/dm/tools/jobsim_client/generate_ensure_graph_data_req.py#newcode80 dm/tools/jobsim_client/generate_ensure_graph_data_req.py:80: 'pool': 'default', 'default' pool exist only on chromium-swarm-dev. ...
4 years, 3 months ago (2016-09-16 18:08:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339413003/40001
4 years, 3 months ago (2016-09-16 18:56:32 UTC) #5
iannucci
https://chromiumcodereview.appspot.com/2339413003/diff/20001/dm/tools/jobsim_client/generate_ensure_graph_data_req.py File dm/tools/jobsim_client/generate_ensure_graph_data_req.py (right): https://chromiumcodereview.appspot.com/2339413003/diff/20001/dm/tools/jobsim_client/generate_ensure_graph_data_req.py#newcode80 dm/tools/jobsim_client/generate_ensure_graph_data_req.py:80: 'pool': 'default', On 2016/09/16 18:08:05, Vadim Sh. wrote: > ...
4 years, 3 months ago (2016-09-16 18:56:33 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:06:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/3e4c54f5b3a1c3304b2cf9cc66705ee4579880e1

Powered by Google App Engine
This is Rietveld 408576698