Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2339393003: Remove some useless code in TabsEventRouter. (Closed)

Created:
4 years, 3 months ago by Patrick Monette
Modified:
4 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some useless code in TabsEventRouter. The TabStripModel is no longer needed inside the event handlers. Committed: https://crrev.com/d29bb8a29d313a1939b297c45b39560ff22a89cb Cr-Commit-Position: refs/heads/master@{#419063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -24 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_event_router.cc View 2 chunks +9 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Patrick Monette
Hi! PTAL at some cleanup.
4 years, 3 months ago (2016-09-16 00:01:24 UTC) #4
Reilly Grant (use Gerrit)
lgtm
4 years, 3 months ago (2016-09-16 00:07:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339393003/1
4 years, 3 months ago (2016-09-16 00:59:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 01:05:21 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 01:07:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d29bb8a29d313a1939b297c45b39560ff22a89cb
Cr-Commit-Position: refs/heads/master@{#419063}

Powered by Google App Engine
This is Rietveld 408576698