Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/chromeos/arc/arc_optin_uma.cc

Issue 2339393002: Separate ARC++ Provisioning Histogram into managed and unmanaged (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/arc_optin_uma.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_optin_uma.cc
diff --git a/chrome/browser/chromeos/arc/arc_optin_uma.cc b/chrome/browser/chromeos/arc/arc_optin_uma.cc
index dd92ecbfc4dd6d69d6a553e23a7c6127142104f3..92ad2c1cddd5901045bfb951c604a912cd5443cc 100644
--- a/chrome/browser/chromeos/arc/arc_optin_uma.cc
+++ b/chrome/browser/chromeos/arc/arc_optin_uma.cc
@@ -22,9 +22,16 @@ void UpdateEnabledStateUMA(bool enabled) {
UMA_HISTOGRAM_BOOLEAN("Arc.State", enabled);
}
-void UpdateProvisioningResultUMA(ProvisioningResult result) {
- UMA_HISTOGRAM_ENUMERATION("Arc.Provisioning.Result", static_cast<int>(result),
- static_cast<int>(ProvisioningResult::SIZE));
+void UpdateProvisioningResultUMA(ProvisioningResult result, bool managed) {
+ if (managed) {
+ UMA_HISTOGRAM_ENUMERATION("Arc.Provisioning.Result.Managed",
Luis Héctor Chávez 2016/09/15 16:00:32 Can you follow the convention in L40 and build the
phweiss 2016/09/15 16:55:51 Yes, but then we cannot use the macro anymore. I'm
Luis Héctor Chávez 2016/09/15 17:22:03 oh that expansion is also gnarlier than the one in
+ static_cast<int>(result),
+ static_cast<int>(ProvisioningResult::SIZE));
+ } else {
+ UMA_HISTOGRAM_ENUMERATION("Arc.Provisioning.Result.Unmanaged",
+ static_cast<int>(result),
+ static_cast<int>(ProvisioningResult::SIZE));
+ }
}
void UpdateProvisioningTiming(const base::TimeDelta& elapsed_time,
« no previous file with comments | « chrome/browser/chromeos/arc/arc_optin_uma.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698