Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2339353004:
Remove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. (Closed)
|
Created:
4 years, 3 months ago by bungeman-chromium Modified:
4 years, 3 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA.
Skia is changing some of its API and one test
subclass needs to be updated to reflect this.
Committed: https://crrev.com/cca1bac5df0dab95911e42b5e98ec88a5fe2501c
Cr-Commit-Position: refs/heads/master@{#419269}
Patch Set 1 #Patch Set 2 : Properly remove the no longer existing virtuals. #
Messages
Total messages: 24 (16 generated)
The CQ bit was checked by bungeman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
Description was changed from ========== Remove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. Skia is changing some of its API to use smart pointers, and one test subclass needs to be updated to reflect this. ========== to ========== Remove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. Skia is changing some of its API and one test subclass needs to be updated to reflect this. ==========
The CQ bit was checked by bungeman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bungeman@chromium.org changed reviewers: + avi@chromium.org
LGTM
The CQ bit was checked by bungeman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
bungeman@google.com changed reviewers: + bungeman@google.com
lgtm
The CQ bit was checked by bungeman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. Skia is changing some of its API and one test subclass needs to be updated to reflect this. ========== to ========== Remove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. Skia is changing some of its API and one test subclass needs to be updated to reflect this. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. Skia is changing some of its API and one test subclass needs to be updated to reflect this. ========== to ========== Remove SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. Skia is changing some of its API and one test subclass needs to be updated to reflect this. Committed: https://crrev.com/cca1bac5df0dab95911e42b5e98ec88a5fe2501c Cr-Commit-Position: refs/heads/master@{#419269} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cca1bac5df0dab95911e42b5e98ec88a5fe2501c Cr-Commit-Position: refs/heads/master@{#419269} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
