Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2339353003: mus: Remove window server access to clipboard and the drag clipboard. (Closed)

Created:
4 years, 3 months ago by Elliot Glaysher
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, dcheng, abarth-chromium, Aaron Boodman, yzshen+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Remove window server access to clipboard and the drag clipboard. This reverts 7d6c8b29f6, which made window server have access to the clipboard, as at the time, I thought that drag and drop would read/write to/from a dedicated drag clipboard and that the window server would have to manipulate it. Due to timing issues, this didn't work out. Now that we aren't using a drag clipboard as the backing for mus drag and drop, also remove the drag clipboard from our mus clipboard implementation. BUG=614037 Committed: https://crrev.com/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2 Cr-Commit-Position: refs/heads/master@{#419260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M services/ui/clipboard/clipboard_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/interfaces/clipboard.mojom View 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/service.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/window_server.h View 4 chunks +0 lines, -6 lines 0 comments Download
M services/ui/ws/window_server.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/views/mus/clipboard_mus.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Elliot Glaysher
Some cleanup now that the main patch is done.
4 years, 3 months ago (2016-09-15 22:45:04 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-15 23:04:53 UTC) #5
Elliot Glaysher
+tsepez for trivial mojo change
4 years, 3 months ago (2016-09-15 23:19:42 UTC) #7
Tom Sepez
Trivial mojom LGTM
4 years, 3 months ago (2016-09-16 19:50:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339353003/1
4 years, 3 months ago (2016-09-16 19:52:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 19:59:13 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 20:02:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98ef46cc289b9cb95cccfb7db520e73ac66b0dc2
Cr-Commit-Position: refs/heads/master@{#419260}

Powered by Google App Engine
This is Rietveld 408576698