Issue 2339303003: Cleanup some Observatory errors caught by dart2js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2339303003: Cleanup some Observatory errors caught by dart2js (Closed)

Created:
4 years, 3 months ago by Cutch

Modified:
4 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Cleanup some Observatory errors caught by dart2js Not sure why the analzyer didn't notice these but dart2js (when invoked via pub serve does). BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/87dcad607ece223a98c46f9185d8c84b1ac53729

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	runtime/observatory/lib/src/elements/debugger.dart	View		4 chunks	+17 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

Cutch

4 years, 3 months ago (2016-09-14 22:45:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
87dcad607ece223a98c46f9185d8c84b1ac53729 (presubmit successful).