Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2339303002: Speculative workaround for VS 2015 code-gen bug (Closed)

Created:
4 years, 3 months ago by brucedawson
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Speculative workaround for VS 2015 code-gen bug On PGO builds (but no others) a pair of functions in process_power_collector.cc get compiled such that the callee returns a floating-point value in xmm0 and the caller looks for it in st(0). The details are in the bug, but if floating-point exceptions are enabled (perhaps happening due to third-party injected software changing the FPU state) then this can lead to crashes. Even without the crashes it is clearly wrong. Since the bug only reproes in PGO it is difficult to test a fix but disabling optimizations around the two functions *should* do the trick. BUG=640588 Review-Url: https://codereview.chromium.org/2329693002 Cr-Commit-Position: refs/heads/master@{#417994} (cherry picked from commit 764c7362bc01b0f1765f2f9043ca89b71a8d0c76) Committed: https://chromium.googlesource.com/chromium/src/+/5c246eb9899a1d95594254b0db36a47e8f9763ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/power/process_power_collector.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
brucedawson
4 years, 3 months ago (2016-09-14 21:10:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c246eb9899a1d95594254b0db36a47e8f9763ae.

Powered by Google App Engine
This is Rietveld 408576698