src/ports/SkFontMgr_win_dw.cpp - Issue 2339273002: SkFontData to use smart pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontMgr_win_dw.cpp

Issue 2339273002: SkFontData to use smart pointers. (Closed)

Patch Set: Add trivial bodies to the trivial implementations. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontMgr_win_dw.cpp

diff --git a/src/ports/SkFontMgr_win_dw.cpp b/src/ports/SkFontMgr_win_dw.cpp

index 833f95bb0ef72c899eec3dc15fdc044a93eb41bf..7201dc10b03b8380d2ccdb14a6ce95a43e9dad44 100644

--- a/src/ports/SkFontMgr_win_dw.cpp

+++ b/src/ports/SkFontMgr_win_dw.cpp

@@ -933,7 +933,7 @@ SkTypeface* SkFontMgr_DirectWrite::onCreateFromData(SkData* data, int ttcIndex)

}

SkTypeface* SkFontMgr_DirectWrite::onCreateFromFile(const char path[], int ttcIndex) const {

- return this->createFromStream(SkStream::NewFromFile(path), ttcIndex);

+ return this->createFromStream(SkStream::MakeFromFile(path).release(), ttcIndex);

}

HRESULT SkFontMgr_DirectWrite::getByFamilyName(const WCHAR wideFamilyName[],

« no previous file with comments | « src/ports/SkFontMgr_fontconfig.cpp ('k') | src/utils/SkWhitelistTypefaces.cpp » ('j') | no next file with comments »