bluetooth: mac: add connected LE devices to chooser

device/bluetooth/test/bluetooth_test_mac.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_TEST_BLUETOOTH_TEST_MAC_H_
 #define DEVICE_BLUETOOTH_TEST_BLUETOOTH_TEST_MAC_H_
 
 #include <memory>
 
 #include "base/test/test_simple_task_runner.h"
@@ skipping 58 matching lines @@
   void SimulateGattNotifySessionStartError(
       BluetoothRemoteGattCharacteristic* characteristic,
       BluetoothRemoteGattService::GattErrorCode error_code) override;
   void SimulateGattCharacteristicChanged(
       BluetoothRemoteGattCharacteristic* characteristic,
       const std::vector<uint8_t>& value) override;
   void SimulateGattCharacteristicRemoved(
       BluetoothRemoteGattService* service,
       BluetoothRemoteGattCharacteristic* characteristic) override;
 
+  // Simulates a connected low energy device. Used before starting a low energy
+  // discovey session.
+  void SimulateConnectedLowEnergyDevice(

[ortuno, 2016/10/31 04:30:51]

Please add this function to bluetooth_test.h and add a more detailed comment to
it. Similar to SimulateLowEnergyDevice.

[jlebel, 2016/11/07 01:43:18]

Done.

+      int device_ordinal,
+      const BluetoothDevice::UUIDSet& service_uuids);

[ortuno, 2016/10/31 04:30:51]

I like the current pattern of just specifying a single value rather than having
to specify name, identifier, uuids, etc. but I dislike that we pass in a number.
Could you please use an enum class instead and just take the enum.

enum class ConnectedDeviceType {
  GENERIC_DEVICE,
  HEART_RATE_DEVICE
}

SimulateLowEnergyDevice(ConnectedDeviceType type);

[jlebel, 2016/11/07 01:43:18]

Done.

+
   // Callback for the bluetooth central manager mock.
   void OnFakeBluetoothDeviceConnectGattCalled();
   void OnFakeBluetoothGattDisconnect();
 
   // Callback for the bluetooth peripheral mock.
   void OnFakeBluetoothServiceDiscovery();
   void OnFakeBluetoothCharacteristicReadValue();
   void OnFakeBluetoothCharacteristicWriteValue(std::vector<uint8_t> value);
   void OnFakeBluetoothGattSetCharacteristicNotification();
 
@@ skipping 13 matching lines @@
   BluetoothAdapterMac* adapter_mac_ = nullptr;
   std::unique_ptr<ScopedMockCentralManager> mock_central_manager_;
 };
 
 // Defines common test fixture name. Use TEST_F(BluetoothTest, YourTestName).
 typedef BluetoothTestMac BluetoothTest;
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_TEST_BLUETOOTH_TEST_MAC_H_